From 9f864b3e9d0650004a957035d08357c2bde81b99 Mon Sep 17 00:00:00 2001 From: "thomasvl@chromium.org" Date: Wed, 20 Jan 2010 15:01:16 +0000 Subject: Turn GetPeerName into a pure virtual and provide local impls, this way any future bugs like the one referenced are compile time and not runtime so they won't wide waiting to be found. BUG=32595 TEST=everything builds and tests pass Review URL: http://codereview.chromium.org/552048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36629 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket/client_socket_pool_base_unittest.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'net/socket/client_socket_pool_base_unittest.cc') diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc index 6f3f5ef..7acebbd 100644 --- a/net/socket/client_socket_pool_base_unittest.cc +++ b/net/socket/client_socket_pool_base_unittest.cc @@ -57,12 +57,10 @@ class MockClientSocket : public ClientSocket { virtual bool IsConnected() const { return connected_; } virtual bool IsConnectedAndIdle() const { return connected_; } -#if defined(OS_LINUX) virtual int GetPeerName(struct sockaddr* /* name */, socklen_t* /* namelen */) { - return 0; + return ERR_UNEXPECTED; } -#endif private: bool connected_; -- cgit v1.1