From c8cb9612733811e0b6cf4a313d35043e8dde6fdc Mon Sep 17 00:00:00 2001 From: "cbentzel@chromium.org" Date: Sat, 23 Oct 2010 12:51:42 +0000 Subject: Revert 63643 - Add Reset to ClientSocket::UseHistory, and call on TCP disconnect. There were a few repeating failures after I landed this CL. They looked unrelated, but I decided to revert since I didn't have a ton of time to continue investigating. Will hopefully reland soon. The HttpProxyClientSocket reuses the same TcpClientSocket in the case that it is trying to establish a tunnel through an authenticating proxy, but the proxy closed the TCP connection. Also, fix SetOmniboxSpeculation on the TCPClientSocket implementations. BUG=54062 TEST=Tried normal connections to make sure histograms were only emitted once, as well as https tunnels through an authenticating proxy to ensure that the use_history was correctly reset. Review URL: http://codereview.chromium.org/3360007 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/4006004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63648 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket/tcp_client_socket_libevent.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'net/socket/tcp_client_socket_libevent.h') diff --git a/net/socket/tcp_client_socket_libevent.h b/net/socket/tcp_client_socket_libevent.h index 72f7d2d..980e4cd 100644 --- a/net/socket/tcp_client_socket_libevent.h +++ b/net/socket/tcp_client_socket_libevent.h @@ -165,9 +165,6 @@ class TCPClientSocketLibevent : public ClientSocket, NonThreadSafe { BoundNetLog net_log_; - // This socket was previously disconnected and has not been re-connected. - bool previously_disconnected_; - // Record of connectivity and transmissions, for use in speculative connection // histograms. UseHistory use_history_; -- cgit v1.1