From 20cb5f48d36abeb25bbf6cdd6a5f6debe014e8b1 Mon Sep 17 00:00:00 2001 From: "jamesr@chromium.org" Date: Wed, 16 Dec 2009 01:01:25 +0000 Subject: Give classes with virtual methods virtual protected destructors instead of implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket/client_socket_pool_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'net/socket') diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h index cfad0a0..897ffec 100644 --- a/net/socket/client_socket_pool_base.h +++ b/net/socket/client_socket_pool_base.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // @@ -451,7 +451,7 @@ class ClientSocketPoolBase { unused_idle_socket_timeout, used_idle_socket_timeout, new ConnectJobFactoryAdaptor(connect_job_factory))) {} - ~ClientSocketPoolBase() {} + virtual ~ClientSocketPoolBase() {} // These member functions simply forward to ClientSocketPoolBaseHelper. -- cgit v1.1