From 4dfabfcfe11281e15bc2a37dad0a73de2ec4b5aa Mon Sep 17 00:00:00 2001 From: "nick@chromium.org" Date: Mon, 2 Aug 2010 22:00:19 +0000 Subject: Revert 54528 - Digest authentication uses a uri field to prevent replay attacks. [Reason for revert: we want to revert r54505, this was a dependent change. cbentzel agrees to reland.] When authenticating to an HTTP proxy to establish a secure tunnel (via CONNECT), the uri should be the hostname of the server and the destination port, such as "www.example.com:443". When authenticating to an HTTP proxy for a non-secure content, the uri should be the path at the server, i.e. "/index.html". If the site we are trying to connect to previously advertised "Alternate-Protocol: 443:spdy-npn/1" a request to "http://www.example.com" will be attempted on a secure port. However, the URL passed into the digest authenticator was an unsecure one, and it decided to have a uri in the form "/index.html" rather than the correct "www.example.com:443". This causes persistent failure with the password and many password prompts. BUG=49865,50822 TEST=Run with --use-spdy=npn, force connection through a digest authenticating proxy, and browse a site which advertises Alternate-Protocol through http URLs. Review URL: http://codereview.chromium.org/3028021 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3091001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54614 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket/socket_test_util.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'net/socket') diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc index 142a39e..ce7f3fc06 100644 --- a/net/socket/socket_test_util.cc +++ b/net/socket/socket_test_util.cc @@ -187,7 +187,6 @@ int MockTCPClientSocket::Connect(net::CompletionCallback* callback) { if (connected_) return net::OK; connected_ = true; - peer_closed_connection_ = false; if (data_->connect_data().async) { RunCallbackAsync(callback, data_->connect_data().result); return net::ERR_IO_PENDING; -- cgit v1.1