From 763f848ffbd28b22a6c2aa32bf28184d9c17b366 Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Fri, 1 Oct 2010 21:23:00 +0000 Subject: FBTF: Another big ctor/dtor cleanup found by automated tools. (Shaves ~2MB off Linux Debug .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61237 0039d316-1c4b-4281-b951-d872f2087c98 --- net/socket_stream/socket_stream_job.cc | 34 +++++++++++++++++++++++++++++++++ net/socket_stream/socket_stream_job.h | 35 ++++++++++------------------------ 2 files changed, 44 insertions(+), 25 deletions(-) (limited to 'net/socket_stream') diff --git a/net/socket_stream/socket_stream_job.cc b/net/socket_stream/socket_stream_job.cc index c8849a5..0913015 100644 --- a/net/socket_stream/socket_stream_job.cc +++ b/net/socket_stream/socket_stream_job.cc @@ -24,4 +24,38 @@ SocketStreamJob* SocketStreamJob::CreateSocketStreamJob( return GetJobManager()->CreateJob(url, delegate); } +SocketStreamJob::SocketStreamJob() {} + +SocketStream::UserData* SocketStreamJob::GetUserData(const void* key) const { + return socket_->GetUserData(key); +} + +void SocketStreamJob::SetUserData(const void* key, + SocketStream::UserData* data) { + socket_->SetUserData(key, data); +} + +void SocketStreamJob::Connect() { + socket_->Connect(); +} + +bool SocketStreamJob::SendData(const char* data, int len) { + return socket_->SendData(data, len); +} + +void SocketStreamJob::Close() { + socket_->Close(); +} + +void SocketStreamJob::RestartWithAuth(const string16& username, + const string16& password) { + socket_->RestartWithAuth(username, password); +} + +void SocketStreamJob::DetachDelegate() { + socket_->DetachDelegate(); +} + +SocketStreamJob::~SocketStreamJob() {} + } // namespace net diff --git a/net/socket_stream/socket_stream_job.h b/net/socket_stream/socket_stream_job.h index 89e0c36..a301709 100644 --- a/net/socket_stream/socket_stream_job.h +++ b/net/socket_stream/socket_stream_job.h @@ -34,17 +34,13 @@ class SocketStreamJob : public base::RefCountedThreadSafe { static SocketStreamJob* CreateSocketStreamJob( const GURL& url, SocketStream::Delegate* delegate); - SocketStreamJob() {} + SocketStreamJob(); void InitSocketStream(SocketStream* socket) { socket_ = socket; } - virtual SocketStream::UserData *GetUserData(const void* key) const { - return socket_->GetUserData(key); - } - virtual void SetUserData(const void* key, SocketStream::UserData* data) { - socket_->SetUserData(key, data); - } + virtual SocketStream::UserData* GetUserData(const void* key) const; + virtual void SetUserData(const void* key, SocketStream::UserData* data); URLRequestContext* context() const { return socket_->context(); @@ -53,31 +49,20 @@ class SocketStreamJob : public base::RefCountedThreadSafe { socket_->set_context(context); } - virtual void Connect() { - socket_->Connect(); - } + virtual void Connect(); - virtual bool SendData(const char* data, int len) { - return socket_->SendData(data, len); - } + virtual bool SendData(const char* data, int len); - virtual void Close() { - socket_->Close(); - } + virtual void Close(); - virtual void RestartWithAuth( - const string16& username, - const string16& password) { - socket_->RestartWithAuth(username, password); - } + virtual void RestartWithAuth(const string16& username, + const string16& password); - virtual void DetachDelegate() { - socket_->DetachDelegate(); - } + virtual void DetachDelegate(); protected: friend class base::RefCountedThreadSafe; - virtual ~SocketStreamJob() {} + virtual ~SocketStreamJob(); scoped_refptr socket_; -- cgit v1.1