From 88e03fa16a2ed1a178822d4ba46dd96a276815a4 Mon Sep 17 00:00:00 2001 From: "rch@chromium.org" Date: Tue, 5 Oct 2010 03:09:04 +0000 Subject: Clarify the semantics of Socket::Read() and Socket::Write(), particularly as they related to closed / disconnected sockets. Added a new ERR_SOCKET_NOT_CONNECTED error which is now returned by GetPeerAddress. This addresses wtc's feedback on CL 3421028. BUG=56423,56426 TEST=none Review URL: http://codereview.chromium.org/3384034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61471 0039d316-1c4b-4281-b951-d872f2087c98 --- net/spdy/spdy_proxy_client_socket_unittest.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'net/spdy/spdy_proxy_client_socket_unittest.cc') diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc index daf158c..274c22f 100644 --- a/net/spdy/spdy_proxy_client_socket_unittest.cc +++ b/net/spdy/spdy_proxy_client_socket_unittest.cc @@ -521,12 +521,14 @@ TEST_F(SpdyProxyClientSocketTest, GetPeerAddressReturnsCorrectValues) { Initialize(reads, arraysize(reads), writes, arraysize(writes)); net::AddressList addr; - EXPECT_EQ(ERR_UNEXPECTED, sock_->GetPeerAddress(&addr)); + EXPECT_EQ(ERR_SOCKET_NOT_CONNECTED, sock_->GetPeerAddress(&addr)); + AssertConnectSucceeds(); EXPECT_TRUE(sock_->IsConnected()); EXPECT_EQ(OK, sock_->GetPeerAddress(&addr)); + sock_->Disconnect(); - EXPECT_EQ(ERR_UNEXPECTED, sock_->GetPeerAddress(&addr)); + EXPECT_EQ(ERR_SOCKET_NOT_CONNECTED, sock_->GetPeerAddress(&addr)); } // ----------- Write -- cgit v1.1