From 1f8859ad6ec7ea807c0330ddf5559e13be5fb26c Mon Sep 17 00:00:00 2001 From: "rvargas@google.com" Date: Sat, 24 Jan 2009 01:54:05 +0000 Subject: Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325 Review URL: http://codereview.chromium.org/18390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98 --- net/url_request/url_request_inet_job.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'net/url_request/url_request_inet_job.cc') diff --git a/net/url_request/url_request_inet_job.cc b/net/url_request/url_request_inet_job.cc index 2d45526..09abfa2 100644 --- a/net/url_request/url_request_inet_job.cc +++ b/net/url_request/url_request_inet_job.cc @@ -185,7 +185,7 @@ void URLRequestInetJob::OnIOComplete(const AsyncResult& result) { } } -bool URLRequestInetJob::ReadRawData(char* dest, int dest_size, +bool URLRequestInetJob::ReadRawData(net::IOBuffer* dest, int dest_size, int *bytes_read) { if (is_done()) return 0; @@ -196,7 +196,7 @@ bool URLRequestInetJob::ReadRawData(char* dest, int dest_size, *bytes_read = 0; - int result = CallInternetRead(dest, dest_size, bytes_read); + int result = CallInternetRead(dest->data(), dest_size, bytes_read); if (result == ERROR_SUCCESS) { DLOG(INFO) << "read " << *bytes_read << " bytes"; if (*bytes_read == 0) -- cgit v1.1