From 778da76f8a401af0eb108889e3e29506d1638bd5 Mon Sep 17 00:00:00 2001 From: "piman@google.com" Date: Wed, 29 Jul 2009 20:52:15 +0000 Subject: linux: unexport as many symbols as possible See discussion on http://code.google.com/p/chromium/issues/detail?id=17557 On linux, exported symbols from a shared library can be overridden by another unit (e.g. the browser) if it exports the same ones. So compile everything with -fvisibility=hidden to make every symbol private by default, and explicitly export the ones that we care about. Also make sure that third-party deps (e.g. icu) don't explicitly export symbols. Review URL: http://codereview.chromium.org/160317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21992 0039d316-1c4b-4281-b951-d872f2087c98 --- o3d/main.scons | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'o3d/main.scons') diff --git a/o3d/main.scons b/o3d/main.scons index d241908..27c52f8 100644 --- a/o3d/main.scons +++ b/o3d/main.scons @@ -684,7 +684,7 @@ linux_env.Append( ['NACL_LINUX', '1'], 'SK_BUILD_FOR_UNIX' ], - CCFLAGS = ['-Wstrict-aliasing', '-m32'], + CCFLAGS = ['-Wstrict-aliasing', '-fvisibility=hidden', '-m32'], LINKFLAGS = ['-m32'], LIBS = ['pthread', 'rt', 'dl'], NACL_HTP_LIBS = ['ssl', 'crypto'], -- cgit v1.1