From a6ba6a64e8a728726336cf8c3126ec6c40b816ba Mon Sep 17 00:00:00 2001 From: "raymes@chromium.org" Date: Wed, 18 Jun 2014 12:58:23 +0000 Subject: Re-enable PDFExtensionTest.BasicPlugin This test was disabled because it was failing. A few changes have been made: -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186 Review URL: https://codereview.chromium.org/290803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278043 0039d316-1c4b-4281-b951-d872f2087c98 --- pdf/out_of_process_instance.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pdf/out_of_process_instance.cc') diff --git a/pdf/out_of_process_instance.cc b/pdf/out_of_process_instance.cc index 8a692c9..9e77ec6 100644 --- a/pdf/out_of_process_instance.cc +++ b/pdf/out_of_process_instance.cc @@ -408,7 +408,7 @@ void OutOfProcessInstance::HandleMessage(const pp::Var& message) { pp::VarDictionary reply; reply.Set(pp::Var(kType), pp::Var(kJSGetAccessibilityJSONReplyType)); if (dict.Get(pp::Var(kJSAccessibilityPageNumber)).is_int()) { - int page = pp::Var(kJSAccessibilityPageNumber).AsInt(); + int page = dict.Get(pp::Var(kJSAccessibilityPageNumber)).AsInt(); reply.Set(pp::Var(kJSAccessibilityJSON), pp::Var(engine_->GetPageAsJSON(page))); } else { -- cgit v1.1