From 108fd342d9f7e0d2073245d1d52cc21ee8253252 Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Fri, 4 Jan 2013 20:46:54 +0000 Subject: Use an explicit PID for duplicating Pepper handles rather than the Channel's. When the browser process launches the plugin, it explicitly tells each side the PID of the other side, and we now use this PID for sharing handles. Previously we'd use the PID from the IPC channel. Using the PID from the IPC channel creates a race condition because the PID isn't set until the "hello" message from the opposite side is processed, which isn't guaranteed at any particular time. BUG=168222 Review URL: https://codereview.chromium.org/11722017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175190 0039d316-1c4b-4281-b951-d872f2087c98 --- ppapi/proxy/host_dispatcher.h | 1 + 1 file changed, 1 insertion(+) (limited to 'ppapi/proxy/host_dispatcher.h') diff --git a/ppapi/proxy/host_dispatcher.h b/ppapi/proxy/host_dispatcher.h index 98a7ad5..1b0c9a7 100644 --- a/ppapi/proxy/host_dispatcher.h +++ b/ppapi/proxy/host_dispatcher.h @@ -58,6 +58,7 @@ class PPAPI_PROXY_EXPORT HostDispatcher : public Dispatcher { // The delegate pointer must outlive this class, ownership is not // transferred. virtual bool InitHostWithChannel(Delegate* delegate, + base::ProcessId peer_pid, const IPC::ChannelHandle& channel_handle, bool is_client, const Preferences& preferences); -- cgit v1.1