From 917e86adc3f824f518c999dcba20bfd4cbf18a18 Mon Sep 17 00:00:00 2001 From: "polina@google.com" Date: Thu, 30 Jun 2011 21:42:37 +0000 Subject: Add a flag field to PP_CompletionCallback to control if the callback should always be invoked asynchronously on success or error or skipped if the operation can complete synchronously without blocking. Keep the default behavior as-is until clients update their code. Bump revisions of all interfaces that take callbacks as args. Update browser interface function implementations and C++ layer to force callbacks if sync option is not set. Change ppapi/tests to run tests involving callbacks with both flag options. BUG=79376 TEST=ppapi_tests + bots Review URL: http://codereview.chromium.org/6899055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91205 0039d316-1c4b-4281-b951-d872f2087c98 --- ppapi/proxy/ppb_broker_proxy.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ppapi/proxy/ppb_broker_proxy.cc') diff --git a/ppapi/proxy/ppb_broker_proxy.cc b/ppapi/proxy/ppb_broker_proxy.cc index fd789de..37f8ba0 100644 --- a/ppapi/proxy/ppb_broker_proxy.cc +++ b/ppapi/proxy/ppb_broker_proxy.cc @@ -204,7 +204,7 @@ void PPB_Broker_Proxy::OnMsgCreate(PP_Instance instance, } void PPB_Broker_Proxy::OnMsgConnect(const HostResource& broker) { - CompletionCallback callback = callback_factory_.NewCallback( + CompletionCallback callback = callback_factory_.NewOptionalCallback( &PPB_Broker_Proxy::ConnectCompleteInHost, broker); int32_t result = ppb_broker_target()->Connect( -- cgit v1.1