From aed965375dec978e7feb8722b1b94250a2a6e039 Mon Sep 17 00:00:00 2001 From: "dmichael@chromium.org" Date: Sat, 23 Jun 2012 14:27:42 +0000 Subject: PPAPI: Make blocking completion callbacks work. This also makes scoped_refptr the "new" way to pass completion callbacks in an API. This allows the Enter object to handle checking for blocking callbacks on the main thread to report error, and blocking if on the background thread. This way, interfaces don't have to write any special cases for blocking callbacks. When built with enable_pepper_threading=1 locally, URLLoader tests all pass for blocking completion callbacks. I haven't updated all tests yet. BUG=92909 TEST= Review URL: https://chromiumcodereview.appspot.com/10081020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143806 0039d316-1c4b-4281-b951-d872f2087c98 --- ppapi/shared_impl/private/ppb_host_resolver_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ppapi/shared_impl/private/ppb_host_resolver_shared.h') diff --git a/ppapi/shared_impl/private/ppb_host_resolver_shared.h b/ppapi/shared_impl/private/ppb_host_resolver_shared.h index d915946..f4eb74a 100644 --- a/ppapi/shared_impl/private/ppb_host_resolver_shared.h +++ b/ppapi/shared_impl/private/ppb_host_resolver_shared.h @@ -50,7 +50,7 @@ class PPAPI_SHARED_EXPORT PPB_HostResolver_Shared virtual int32_t Resolve(const char* host, uint16_t port, const PP_HostResolver_Private_Hint* hint, - PP_CompletionCallback callback) OVERRIDE; + scoped_refptr callback) OVERRIDE; virtual PP_Var GetCanonicalName() OVERRIDE; virtual uint32_t GetSize() OVERRIDE; virtual bool GetNetAddress(uint32_t index, -- cgit v1.1