From ea441832f9f20a18a465327ce7c727afc1ed5e8a Mon Sep 17 00:00:00 2001 From: "teravest@chromium.org" Date: Wed, 5 Feb 2014 15:34:21 +0000 Subject: Pepper: Log in UMA when an interface is used. We'd like to know what versions of our interfaces are used by end users. This change logs usage of PPB interfaces for out-of-process plugins the first time that get_interface<>() is called for a given interface and version. I tested this change by loading some plugin examples and checking the about:histograms page. BUG=111542 R=asvitkine@chromium.org, jschuh@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/141523010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249007 0039d316-1c4b-4281-b951-d872f2087c98 --- ppapi/thunk/interfaces_ppb_public_stable.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'ppapi/thunk') diff --git a/ppapi/thunk/interfaces_ppb_public_stable.h b/ppapi/thunk/interfaces_ppb_public_stable.h index afbf19b..45ce4d7 100644 --- a/ppapi/thunk/interfaces_ppb_public_stable.h +++ b/ppapi/thunk/interfaces_ppb_public_stable.h @@ -7,7 +7,13 @@ // This file contains lists of interfaces. It's intended to be included by // another file which defines implementations of the macros. This allows files // to do specific registration tasks for each supported interface. - +// +// When adding an interface, you must also add the hash value for the +// interface's name to tools/metrics/histograms/histograms.xml. This is so we +// get human-readable UMA tracking for interface usage. +// +// Use the 'pepper_hash_for_uma' tool in ppapi/tools to determine the hash for +// a given interface string. // Api categories // -------------- -- cgit v1.1