From 252014f95ffbc88c6b627bb1a1fa4ff019096707 Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" Date: Tue, 31 May 2011 15:19:05 +0000 Subject: Give FunctionGroupBase a virtual destructor. HostDispatcher has a scoped_ptr, so without this, it won't invoke destructors of objects implenting FunctionGroupBase (i.e. this is a real bug.) Found by clang's -Wdelete-non-virtual-dtor BUG=84424 TEST=none Review URL: http://codereview.chromium.org/7084034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87306 0039d316-1c4b-4281-b951-d872f2087c98 --- ppapi/shared_impl/function_group_base.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'ppapi') diff --git a/ppapi/shared_impl/function_group_base.h b/ppapi/shared_impl/function_group_base.h index 9cdfcc6..4f98396 100644 --- a/ppapi/shared_impl/function_group_base.h +++ b/ppapi/shared_impl/function_group_base.h @@ -16,6 +16,8 @@ class ResourceCreationAPI; class FunctionGroupBase { public: + virtual ~FunctionGroupBase() {} + // Dynamic casting for this object. Returns the pointer to the given type if // it's supported. virtual thunk::PPB_CharSet_FunctionAPI* AsCharSet_FunctionAPI() { -- cgit v1.1