From e5324b55e4204451d02d9323a6ea013955b82bc0 Mon Sep 17 00:00:00 2001 From: "vitalybuka@chromium.org" Date: Tue, 29 Oct 2013 03:16:37 +0000 Subject: De-duplicate job_settings parsing code. Proper set/get methods in PrintSettings. Objective of this re-factoring is to simplify processing of "print_to_pdf || is_cloud_dialog || print_to_cloud" case. Now all platforms for this case do almost the same by in different way: calculate and set printing area. In the next CL I'll move that code into common PrintingContext::UpdatePrintSettings and will ask platform specific implementation for desired page size only. BUG=305731 Review URL: https://codereview.chromium.org/47823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231501 0039d316-1c4b-4281-b951-d872f2087c98 --- printing/print_settings_initializer.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'printing/print_settings_initializer.h') diff --git a/printing/print_settings_initializer.h b/printing/print_settings_initializer.h index 4897be8..a1093c5 100644 --- a/printing/print_settings_initializer.h +++ b/printing/print_settings_initializer.h @@ -7,6 +7,7 @@ #include "base/basictypes.h" #include "base/logging.h" +#include "printing/page_range.h" #include "printing/printing_export.h" namespace base { @@ -21,8 +22,9 @@ class PrintSettings; // provided |job_settings|. class PRINTING_EXPORT PrintSettingsInitializer { public: - static void InitHeaderFooterStrings( + static bool InitSettings( const base::DictionaryValue& job_settings, + const PageRanges& ranges, PrintSettings* print_settings); private: -- cgit v1.1