From a109fd05fac9af35d219de6e428530180cf582b2 Mon Sep 17 00:00:00 2001 From: "jamesr@chromium.org" Date: Thu, 10 Jul 2014 07:41:43 +0000 Subject: Provide gtest printers for ui/gfx geometry types This provides PrintTo(..) functions for the geometric types in ui/gfx/ so that failing gtest assertions pretty-print the values instead of dumping the bytes of the objects. This way gtest assertions on these types can be written in the form: EXPECT_EQ(a, b); instead of EXPECT_EQ(a.ToString(), b.ToString()); which is currently used (inconsistently) to provide more readable failure messages. This is a bit tricky since gtest uses streams and somewhat complicated template expansion magic to pretty print values and we don't want to link the stream-based code into production code paths. This declares the PrintTo() functions in the headers defining each of the geometry types, using the header to keep stream bloat to a minimum, and defines the formatters in gfx_test_support. This way every test that instantiates these printers has to declare a dependency on gfx_test_support or it fails to link, but a test does not have to #include any particular header to see the correct printer declaration and thus expand the template correctly. If we were to declare the PrintTo() functions in a test only header such a gfx_util.h then the pretty printers would work reliably only if *every* target in a translation unit that instantiated the comparison saw this declaration. If some unit tests in a target #included the header and some did not then it would be intederminate whether the template instantiation linked in to the test binary was the pretty printed one or the hex dump one (and in practice this appears to be inconsistent across clang and gcc for whatever reason). Review URL: https://codereview.chromium.org/368903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282270 0039d316-1c4b-4281-b951-d872f2087c98 --- printing/printing.gyp | 1 + 1 file changed, 1 insertion(+) (limited to 'printing/printing.gyp') diff --git a/printing/printing.gyp b/printing/printing.gyp index bfec0fc..7ab3c09 100644 --- a/printing/printing.gyp +++ b/printing/printing.gyp @@ -214,6 +214,7 @@ '../ui/base/ui_base.gyp:ui_base', '../ui/gfx/gfx.gyp:gfx', '../ui/gfx/gfx.gyp:gfx_geometry', + '../ui/gfx/gfx.gyp:gfx_test_support', 'printing', ], 'sources': [ -- cgit v1.1