From 89331d3564a0dffb3fc2f6c13b3734748f01a1b3 Mon Sep 17 00:00:00 2001 From: "alexeypa@chromium.org" Date: Wed, 28 Nov 2012 16:33:24 +0000 Subject: Do not include memory referenced by locals and other stack memory to the dump. This memory is valuable during debugging but it increases size of minidumps beyond the accepted limit. The result is the dumps are not processed at all and we don't get any information. BUG=162914 Review URL: https://chromiumcodereview.appspot.com/11299213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169963 0039d316-1c4b-4281-b951-d872f2087c98 --- remoting/base/breakpad_win.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'remoting/base') diff --git a/remoting/base/breakpad_win.cc b/remoting/base/breakpad_win.cc index ef16a24..d083ceed 100644 --- a/remoting/base/breakpad_win.cc +++ b/remoting/base/breakpad_win.cc @@ -112,12 +112,10 @@ BreakpadWin::BreakpadWin() : handling_exception_(0) { if (length == 0) return; - // Minidump with stacks, PEB, TEB, unloaded module list and memory referenced - // from stack. + // Minidump with stacks, PEB, TEBs and unloaded module list. MINIDUMP_TYPE dump_type = static_cast( MiniDumpWithProcessThreadData | - MiniDumpWithUnloadedModules | - MiniDumpWithIndirectlyReferencedMemory); + MiniDumpWithUnloadedModules); breakpad_.reset( new google_breakpad::ExceptionHandler( temp_directory, &OnExceptionCallback, NULL, NULL, -- cgit v1.1