From c9d7eff1fd9eefb46b27a3d6f4ecda16a9299122 Mon Sep 17 00:00:00 2001 From: piman Date: Tue, 5 May 2015 12:17:36 -0700 Subject: Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #4 id:60001 of https://codereview.chromium.org/1114383003/) Reason for revert: Suspected cause of IOS failure https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26420/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-05-113310%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1114353005 Cr-Commit-Position: refs/heads/master@{#328375} --- remoting/base/buffered_socket_writer_unittest.cc | 8 -------- 1 file changed, 8 deletions(-) (limited to 'remoting/base') diff --git a/remoting/base/buffered_socket_writer_unittest.cc b/remoting/base/buffered_socket_writer_unittest.cc index 07bb2ec..0c74044 100644 --- a/remoting/base/buffered_socket_writer_unittest.cc +++ b/remoting/base/buffered_socket_writer_unittest.cc @@ -45,14 +45,6 @@ class SocketDataProvider: public net::SocketDataProvider { size); } - bool AllReadDataConsumed() const override { - return true; - } - - bool AllWriteDataConsumed() const override { - return true; - } - void Reset() override {} std::string written_data() { return written_data_; } -- cgit v1.1