From 6b302a8670e0562c7196c5438bacfc57b6937816 Mon Sep 17 00:00:00 2001 From: "wez@chromium.org" Date: Wed, 25 May 2011 04:23:29 +0000 Subject: Fix crash condition if caller deletes PseudoTcpAdaptor from within a callback. BUG=82171 TEST= Review URL: http://codereview.chromium.org/7040021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86570 0039d316-1c4b-4281-b951-d872f2087c98 --- remoting/protocol/jingle_session.cc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'remoting/protocol') diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc index 60fab26..90aaf08 100644 --- a/remoting/protocol/jingle_session.cc +++ b/remoting/protocol/jingle_session.cc @@ -381,6 +381,8 @@ bool JingleSession::EstablishSSLConnection( new jingle_glue::PseudoTcpAdapter(channel); pseudotcp->Connect(&connect_callback_); + // TODO(wez): We shouldn't try to start SSL until the socket we're + // starting it on is connected. if (cricket_session_->initiator()) { // Create client SSL socket. net::SSLClientSocket* socket = CreateSSLClientSocket( -- cgit v1.1