From 5816f58abd0d2b08d118924ed9240195a0a23716 Mon Sep 17 00:00:00 2001 From: jamiewalch Date: Fri, 25 Sep 2015 12:30:44 -0700 Subject: Refactor HostSettings class. There are four main changes: * Rename HostSettings to HostOptions (since the functionality it provides was previously provided by Host.Options). * Make all fields optional. This was in response to a comment on https://codereview.chromium.org/1343503002/ that using an empty set of remappings to represent the default doesn't make much sense. I extended it to apply to all settings. * Move the default key remapping logic into getRemapKeys(). * Move the string->dictionary key remapping logic into setRemapKeys(). Review URL: https://codereview.chromium.org/1358173005 Cr-Commit-Position: refs/heads/master@{#350886} --- remoting/remoting_webapp_files.gypi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'remoting/remoting_webapp_files.gypi') diff --git a/remoting/remoting_webapp_files.gypi b/remoting/remoting_webapp_files.gypi index f15f196..5e90ca7 100644 --- a/remoting/remoting_webapp_files.gypi +++ b/remoting/remoting_webapp_files.gypi @@ -93,6 +93,7 @@ 'webapp/base/js/dns_blackhole_checker_unittest.js', 'webapp/base/js/error_unittest.js', 'webapp/base/js/fallback_signal_strategy_unittest.js', + 'webapp/base/js/host_options_unittest.js', 'webapp/base/js/identity_unittest.js', 'webapp/base/js/ipc_unittest.js', 'webapp/base/js/l10n_unittest.js', @@ -207,7 +208,7 @@ # Host JavaScript files. 'remoting_webapp_shared_js_host_files': [ 'webapp/base/js/host.js', - 'webapp/base/js/host_settings.js', + 'webapp/base/js/host_options.js', ], # Logging and stats JavaScript files. 'remoting_webapp_shared_js_logging_files': [ -- cgit v1.1