From 861e7ec31c1917c3c7447356be2a8a26cf8588b3 Mon Sep 17 00:00:00 2001 From: dbeam Date: Mon, 4 May 2015 20:56:16 -0700 Subject: Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/) Reason for revert: Final stop on the revert train! net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this? https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg) Here's a log of the break: https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1119803006 Cr-Commit-Position: refs/heads/master@{#328271} --- remoting/base/buffered_socket_writer_unittest.cc | 8 -------- remoting/signaling/xmpp_signal_strategy_unittest.cc | 8 -------- 2 files changed, 16 deletions(-) (limited to 'remoting') diff --git a/remoting/base/buffered_socket_writer_unittest.cc b/remoting/base/buffered_socket_writer_unittest.cc index 07bb2ec..0c74044 100644 --- a/remoting/base/buffered_socket_writer_unittest.cc +++ b/remoting/base/buffered_socket_writer_unittest.cc @@ -45,14 +45,6 @@ class SocketDataProvider: public net::SocketDataProvider { size); } - bool AllReadDataConsumed() const override { - return true; - } - - bool AllWriteDataConsumed() const override { - return true; - } - void Reset() override {} std::string written_data() { return written_data_; } diff --git a/remoting/signaling/xmpp_signal_strategy_unittest.cc b/remoting/signaling/xmpp_signal_strategy_unittest.cc index 2193982..b4c4a53 100644 --- a/remoting/signaling/xmpp_signal_strategy_unittest.cc +++ b/remoting/signaling/xmpp_signal_strategy_unittest.cc @@ -29,14 +29,6 @@ class XmppSocketDataProvider: public net::SocketDataProvider { void Reset() override {} - bool AllReadDataConsumed() const override { - return true; - } - - bool AllWriteDataConsumed() const override { - return true; - } - void ReceiveData(const std::string& text) { socket()->OnReadComplete( net::MockRead(net::ASYNC, text.data(), text.size())); -- cgit v1.1