From b96fc5dc177d311db220dc4039e74a9c0d871558 Mon Sep 17 00:00:00 2001 From: "sgk@google.com" Date: Thu, 18 Dec 2008 23:26:29 +0000 Subject: Convert from using env['PLATFORM'] directly to using the more flexible and better-thought-out Hammer env.Bits() idioms: * env['PLATFORM'] == 'win32' => env.Bit('windows') * env['PLATFORM'] == 'posix' => env.Bit('linux') * env['PLATFORM'] == 'darwin' => env.Bit('mac') New idioms: * env.Bit('posix') => really does mean "any POSIX platform" * env.AnyBits('mac', 'linux') => specifically mac or linux, excluding other POSIX platforms Where we were using compound conditionals (e.g., "env['PLATFORM'] in ('posix', 'darwin')") I tried to take my best shot at translating the intent (i.e., "env.Bits('posix')" for something POSIX, "not env.Bits('mac')" for something not yet ported to Mac, etc.) Review URL: http://codereview.chromium.org/15051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98 --- sandbox/src/sandbox_lib.scons | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sandbox/src') diff --git a/sandbox/src/sandbox_lib.scons b/sandbox/src/sandbox_lib.scons index 493f3be..0189114 100644 --- a/sandbox/src/sandbox_lib.scons +++ b/sandbox/src/sandbox_lib.scons @@ -10,7 +10,7 @@ env.ApplySConscript([ '$GTEST_DIR/../using_gtest.scons', ]) -if env['PLATFORM'] == 'win32': +if env.Bit('windows'): env.Append( CCFLAGS = [ '/WX', # treat warnings as errors -- cgit v1.1