From 2c56af1a6677c9b1141778173dcb1b3bdb63f14b Mon Sep 17 00:00:00 2001 From: "nsylvain@chromium.org" Date: Thu, 13 Nov 2008 22:06:07 +0000 Subject: Return the right error code when we proxy a call to the broker. IIRC we decided to always return access denied because we did not want to leak the real error code, but this is bogus for 2 reasons: 1. The broker will return access denied if it's not allowed in the policy 2. The check to hide the return code is in the renderer, so it would have been possible for a malicious user to see it anyway. I also added a test for it. BUG:3965 Review URL: http://codereview.chromium.org/10615 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5388 0039d316-1c4b-4281-b951-d872f2087c98 --- sandbox/tests/common/controller.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sandbox/tests') diff --git a/sandbox/tests/common/controller.h b/sandbox/tests/common/controller.h index 8d9038f..1584f57 100644 --- a/sandbox/tests/common/controller.h +++ b/sandbox/tests/common/controller.h @@ -25,7 +25,8 @@ enum SboxTestResult { SBOX_TEST_SUCCEEDED, SBOX_TEST_PING_OK, SBOX_TEST_FIRST_INFO = SBOX_TEST_FIRST_RESULT | SEVERITY_INFO_FLAGS, - SBOX_TEST_DENIED, + SBOX_TEST_DENIED, // Access was denied. + SBOX_TEST_NOT_FOUND, // The resource was not found. SBOX_TEST_FIRST_ERROR = SBOX_TEST_FIRST_RESULT | SEVERITY_ERROR_FLAGS, SBOX_TEST_INVALID_PARAMETER, SBOX_TEST_FAILED_TO_RUN_TEST, -- cgit v1.1