From ffe88f7578d07e1924d88abc9e4b6e3d112e6345 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Fri, 4 Sep 2009 20:55:11 +0000 Subject: Delete all precompiled support. It is causing more harm than good, especially when define changes. TEST=none BUG=20889 Review URL: http://codereview.chromium.org/171118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25511 0039d316-1c4b-4281-b951-d872f2087c98 --- sandbox/sandbox.gyp | 60 ------------------------------- sandbox/sandbox_poc/pocdll/stdafx.cc | 8 ----- sandbox/sandbox_poc/pocdll/stdafx.h | 12 ------- sandbox/sandbox_poc/stdafx.cc | 5 --- sandbox/sandbox_poc/stdafx.h | 18 ---------- sandbox/src/stdafx.cc | 5 --- sandbox/src/stdafx.h | 12 ------- sandbox/tests/integration_tests/stdafx.cc | 5 --- sandbox/tests/integration_tests/stdafx.h | 12 ------- sandbox/tests/unit_tests/stdafx.cc | 5 --- sandbox/tests/unit_tests/stdafx.h | 12 ------- sandbox/tests/validation_tests/stdafx.cc | 5 --- sandbox/tests/validation_tests/stdafx.h | 13 ------- sandbox/tools/finder/stdafx.cc | 8 ----- sandbox/tools/finder/stdafx.h | 19 ---------- sandbox/tools/launcher/stdafx.cc | 8 ----- sandbox/tools/launcher/stdafx.h | 20 ----------- 17 files changed, 227 deletions(-) delete mode 100644 sandbox/sandbox_poc/pocdll/stdafx.cc delete mode 100644 sandbox/sandbox_poc/pocdll/stdafx.h delete mode 100644 sandbox/sandbox_poc/stdafx.cc delete mode 100644 sandbox/sandbox_poc/stdafx.h delete mode 100644 sandbox/src/stdafx.cc delete mode 100644 sandbox/src/stdafx.h delete mode 100644 sandbox/tests/integration_tests/stdafx.cc delete mode 100644 sandbox/tests/integration_tests/stdafx.h delete mode 100644 sandbox/tests/unit_tests/stdafx.cc delete mode 100644 sandbox/tests/unit_tests/stdafx.h delete mode 100644 sandbox/tests/validation_tests/stdafx.cc delete mode 100644 sandbox/tests/validation_tests/stdafx.h delete mode 100644 sandbox/tools/finder/stdafx.cc delete mode 100644 sandbox/tools/finder/stdafx.h delete mode 100644 sandbox/tools/launcher/stdafx.cc delete mode 100644 sandbox/tools/launcher/stdafx.h (limited to 'sandbox') diff --git a/sandbox/sandbox.gyp b/sandbox/sandbox.gyp index e389171..bc7c054 100644 --- a/sandbox/sandbox.gyp +++ b/sandbox/sandbox.gyp @@ -198,10 +198,6 @@ 'src/win_utils.h', 'src/window.h', 'src/window.cc', - - # Precompiled headers. - 'src/stdafx.cc', - 'src/stdafx.h', ], 'include_dirs': [ '..', @@ -215,12 +211,6 @@ ], }, ], - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'src/stdafx.h', - 'msvs_precompiled_source': 'src/stdafx.cc', - }, - }, 'direct_dependent_settings': { 'include_dirs': [ 'src', @@ -250,17 +240,7 @@ 'src/registry_policy_test.cc', 'src/sync_policy_test.cc', 'src/unload_dll_test.cc', - - # Precompiled headers. - 'tests/integration_tests/stdafx.cc', - 'tests/integration_tests/stdafx.h', ], - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'tests/integration_tests/stdafx.h', - 'msvs_precompiled_source': 'tests/integration_tests/stdafx.cc', - }, - }, }, { 'target_name': 'sbox_validation_tests', @@ -276,17 +256,7 @@ 'tests/validation_tests/commands.cc', 'tests/validation_tests/commands.h', 'tests/validation_tests/suite.cc', - - # Precompiled headers. - 'tests/validation_tests/stdafx.cc', - 'tests/validation_tests/stdafx.h', ], - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'tests/validation_tests/stdafx.h', - 'msvs_precompiled_source': 'tests/validation_tests/stdafx.cc', - }, - }, }, { 'target_name': 'sbox_unittests', @@ -308,17 +278,7 @@ 'src/policy_opcodes_unittest.cc', 'src/ipc_unittest.cc', 'src/threadpool_unittest.cc', - - # Precompiled headers. - 'tests/unit_tests/stdafx.cc', - 'tests/unit_tests/stdafx.h', ], - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'tests/unit_tests/stdafx.h', - 'msvs_precompiled_source': 'tests/unit_tests/stdafx.cc', - }, - }, }, { 'target_name': 'sandbox_poc', @@ -335,10 +295,6 @@ 'sandbox_poc/sandbox.h', 'sandbox_poc/sandbox.ico', 'sandbox_poc/sandbox.rc', - - # Precompiled headers. - 'sandbox_poc/stdafx.cc', - 'sandbox_poc/stdafx.h', ], 'link_settings': { 'libraries': [ @@ -350,12 +306,6 @@ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS }, }, - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'sandbox_poc/stdafx.h', - 'msvs_precompiled_source': 'sandbox_poc/stdafx.cc', - }, - }, }, { 'target_name': 'pocdll', @@ -371,10 +321,6 @@ 'sandbox_poc/pocdll/registry.cc', 'sandbox_poc/pocdll/spyware.cc', 'sandbox_poc/pocdll/utils.h', - - # Precompiled headers. - 'sandbox_poc/pocdll/stdafx.cc', - 'sandbox_poc/pocdll/stdafx.h', ], 'defines': [ 'POCDLL_EXPORTS', @@ -382,12 +328,6 @@ 'include_dirs': [ '..', ], - 'configurations': { - 'Debug': { - 'msvs_precompiled_header': 'sandbox_poc/pocdll/stdafx.h', - 'msvs_precompiled_source': 'sandbox_poc/pocdll/stdafx.cc', - }, - }, }, ], }], diff --git a/sandbox/sandbox_poc/pocdll/stdafx.cc b/sandbox/sandbox_poc/pocdll/stdafx.cc deleted file mode 100644 index a06f0d1..0000000 --- a/sandbox/sandbox_poc/pocdll/stdafx.cc +++ /dev/null @@ -1,8 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/sandbox_poc/pocdll/stdafx.h" - -// TODO: reference any additional headers you need in STDAFX.H -// and not in this file diff --git a/sandbox/sandbox_poc/pocdll/stdafx.h b/sandbox/sandbox_poc/pocdll/stdafx.h deleted file mode 100644 index a473564..0000000 --- a/sandbox/sandbox_poc/pocdll/stdafx.h +++ /dev/null @@ -1,12 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_SANDBOX_POC_POCDLL_STDAFX_H__ -#define SANDBOX_SANDBOX_POC_POCDLL_STDAFX_H__ - -#include -#include -#include - -#endif // SANDBOX_SANDBOX_POC_POCDLL_STDAFX_H__ diff --git a/sandbox/sandbox_poc/stdafx.cc b/sandbox/sandbox_poc/stdafx.cc deleted file mode 100644 index 606e8e8..0000000 --- a/sandbox/sandbox_poc/stdafx.cc +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/sandbox_poc/stdafx.h" diff --git a/sandbox/sandbox_poc/stdafx.h b/sandbox/sandbox_poc/stdafx.h deleted file mode 100644 index 8bf7354..0000000 --- a/sandbox/sandbox_poc/stdafx.h +++ /dev/null @@ -1,18 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_SANDBOX_POC_STDAFX_H__ -#define SANDBOX_SANDBOX_POC_STDAFX_H__ - -#include -#include -#include -#include -#include - -#define _ATL_NO_EXCEPTIONS -#include -#include - -#endif // SANDBOX_SANDBOX_POC_STDAFX_H__ diff --git a/sandbox/src/stdafx.cc b/sandbox/src/stdafx.cc deleted file mode 100644 index b1da090..0000000 --- a/sandbox/src/stdafx.cc +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/src/stdafx.h" diff --git a/sandbox/src/stdafx.h b/sandbox/src/stdafx.h deleted file mode 100644 index e575344..0000000 --- a/sandbox/src/stdafx.h +++ /dev/null @@ -1,12 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_SRC_STDAFX_H__ -#define SANDBOX_SRC_STDAFX_H__ - -#include -#include -#include - -#endif // SANDBOX_SRC_STDAFX_H__ diff --git a/sandbox/tests/integration_tests/stdafx.cc b/sandbox/tests/integration_tests/stdafx.cc deleted file mode 100644 index e557e72..0000000 --- a/sandbox/tests/integration_tests/stdafx.cc +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/tests/integration_tests/stdafx.h" diff --git a/sandbox/tests/integration_tests/stdafx.h b/sandbox/tests/integration_tests/stdafx.h deleted file mode 100644 index e7877cf..0000000 --- a/sandbox/tests/integration_tests/stdafx.h +++ /dev/null @@ -1,12 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_TESTS_INTEGRATION_TESTS_STDAFX_H__ -#define SANDBOX_TESTS_INTEGRATION_TESTS_STDAFX_H__ - -#include -#include -#include - -#endif // SANDBOX_TESTS_INTEGRATION_TESTS_STDAFX_H__ diff --git a/sandbox/tests/unit_tests/stdafx.cc b/sandbox/tests/unit_tests/stdafx.cc deleted file mode 100644 index f0b684b..0000000 --- a/sandbox/tests/unit_tests/stdafx.cc +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/tests/unit_tests/stdafx.h" diff --git a/sandbox/tests/unit_tests/stdafx.h b/sandbox/tests/unit_tests/stdafx.h deleted file mode 100644 index 05397e0..0000000 --- a/sandbox/tests/unit_tests/stdafx.h +++ /dev/null @@ -1,12 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_TESTS_UNIT_TESTS_STDAFX_H__ -#define SANDBOX_TESTS_UNIT_TESTS_STDAFX_H__ - -#include -#include -#include - -#endif // SANDBOX_TESTS_UNIT_TESTS_STDAFX_H__ diff --git a/sandbox/tests/validation_tests/stdafx.cc b/sandbox/tests/validation_tests/stdafx.cc deleted file mode 100644 index fcce090..0000000 --- a/sandbox/tests/validation_tests/stdafx.cc +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/tests/validation_tests/stdafx.h" diff --git a/sandbox/tests/validation_tests/stdafx.h b/sandbox/tests/validation_tests/stdafx.h deleted file mode 100644 index 9df7b84..0000000 --- a/sandbox/tests/validation_tests/stdafx.h +++ /dev/null @@ -1,13 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_TESTS_VALIDATION_TESTS_STDAFX_H_ -#define SANDBOX_TESTS_VALIDATION_TESTS_STDAFX_H_ - -#include -#include -#include -#include - -#endif // SANDBOX_TESTS_VALIDATION_TESTS_STDAFX_H_ diff --git a/sandbox/tools/finder/stdafx.cc b/sandbox/tools/finder/stdafx.cc deleted file mode 100644 index 407f549..0000000 --- a/sandbox/tools/finder/stdafx.cc +++ /dev/null @@ -1,8 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/tools/finder/stdafx.h" - -// TODO: reference any additional headers you need in STDAFX.H -// and not in this file diff --git a/sandbox/tools/finder/stdafx.h b/sandbox/tools/finder/stdafx.h deleted file mode 100644 index f5b821b..0000000 --- a/sandbox/tools/finder/stdafx.h +++ /dev/null @@ -1,19 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_TOOLS_FINDER_STDAFX_H__ -#define SANDBOX_TOOLS_FINDER_STDAFX_H__ - -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif - -#include -#include -#include -#define _ATL_NO_EXCEPTIONS -#include -#include - -#endif // SANDBOX_TOOLS_FINDER_STDAFX_H__ diff --git a/sandbox/tools/launcher/stdafx.cc b/sandbox/tools/launcher/stdafx.cc deleted file mode 100644 index 3b4ef15..0000000 --- a/sandbox/tools/launcher/stdafx.cc +++ /dev/null @@ -1,8 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "sandbox/tools/launcher/stdafx.h" - -// TODO: reference any additional headers you need in STDAFX.H -// and not in this file diff --git a/sandbox/tools/launcher/stdafx.h b/sandbox/tools/launcher/stdafx.h deleted file mode 100644 index 297195c..0000000 --- a/sandbox/tools/launcher/stdafx.h +++ /dev/null @@ -1,20 +0,0 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef SANDBOX_TOOLS_LAUNCHER_STDAFX_H__ -#define SANDBOX_TOOLS_LAUNCHER_STDAFX_H__ - -#ifndef _WIN32_WINNT -#define _WIN32_WINNT 0x0501 -#endif - -#include -#include -#include -#define _ATL_NO_EXCEPTIONS -#include -#include -#include - -#endif // SANDBOX_TOOLS_LAUNCHER_STDAFX_H__ -- cgit v1.1