From b1e75f52fbac55e600415cd428dc40a6a68fe90b Mon Sep 17 00:00:00 2001 From: "brettw@google.com" Date: Wed, 5 Nov 2008 16:43:50 +0000 Subject: Rollback r4734 to see if it fixes the crashing I experience when starting chrome, as well as the 1MB regression in chrome.dll size. Review URL: http://codereview.chromium.org/8226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4781 0039d316-1c4b-4281-b951-d872f2087c98 --- site_scons/site_tools/component_targets_msvs.py | 9 +-------- site_scons/site_tools/visual_studio_solution.py | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) (limited to 'site_scons') diff --git a/site_scons/site_tools/component_targets_msvs.py b/site_scons/site_tools/component_targets_msvs.py index e86de89..57be5b3 100755 --- a/site_scons/site_tools/component_targets_msvs.py +++ b/site_scons/site_tools/component_targets_msvs.py @@ -105,9 +105,7 @@ def ComponentVSProjectBuilder(target, source, env): project_file = target[0].path project_to_main = env.RelativePath(target[0].dir, env.Dir('$MAIN_DIR'), sep='/') - - env_hammer_bat = env.Clone(VS_PROJECT_TO_MAIN_DIR=project_to_main) - hammer_bat = env_hammer_bat.subst('$COMPONENT_VS_PROJECT_SCRIPT_PATH', raw=1) + hammer_bat = '$(ProjectDir)/%s/hammer.bat' % project_to_main # Project header xml_impl = xml.dom.getDOMImplementation() @@ -435,10 +433,6 @@ def generate(env): COMPONENT_VS_PROJECT_DIR='$COMPONENT_VS_SOLUTION_DIR/projects', COMPONENT_VS_SOLUTION_SUFFIX='.sln', COMPONENT_VS_PROJECT_SUFFIX='.vcproj', - COMPONENT_VS_PROJECT_SCRIPT_NAME = 'hammer.bat', - COMPONENT_VS_PROJECT_SCRIPT_PATH = ( - '$$(ProjectDir)/$VS_PROJECT_TO_MAIN_DIR/' - '$COMPONENT_VS_PROJECT_SCRIPT_NAME'), ) AddTargetGroup('all_solutions', 'solutions can be built') @@ -447,7 +441,6 @@ def generate(env): vcprojaction = SCons.Script.Action(ComponentVSProjectBuilder, varlist=[ 'TARGET_NAME', 'TARGET_PATH', - 'COMPONENT_VS_PROJECT_SCRIPT_PATH', ]) vcprojbuilder = SCons.Script.Builder( action=vcprojaction, diff --git a/site_scons/site_tools/visual_studio_solution.py b/site_scons/site_tools/visual_studio_solution.py index 1e46767..4c18d23 100644 --- a/site_scons/site_tools/visual_studio_solution.py +++ b/site_scons/site_tools/visual_studio_solution.py @@ -71,7 +71,7 @@ def Solution(env, solution_name, build_targets = [e.subst('$TARGET_ROOT') for e in environments] # pick out sources, headers, and resources sources, headers, resources, others = env.GatherInputs( - [env.Dir('$DESTINATION_ROOT')], + [SCons.Script.Dir('$DESTINATION_ROOT')], ['.+\\.(c|cc|m|mm|cpp)$', # source files '.+\\.(h|hh|hpp)$', # header files '.+\\.(rc)$', # resource files -- cgit v1.1