From bf5c7263c413a5bb2e953ea130635ec1c2728892 Mon Sep 17 00:00:00 2001 From: "jamesr@chromium.org" Date: Fri, 15 Nov 2013 00:56:28 +0000 Subject: Set SK_DEFAULT_FONT_CACHE_COUNT_LIMIT=256 on windows only Having this limit be 256 instead of the default 2k seems to hurt the page cyclers on mac. 256 and 2048 seem the same on windows, and having the limit be high on windows can cause more serious problems due to GDI handle limits. R=cpu@chromium.org, cpu TBR=reed NOTRY=true BUG=314387 Review URL: https://codereview.chromium.org/59883016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235268 0039d316-1c4b-4281-b951-d872f2087c98 --- skia/skia_library.gypi | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'skia/skia_library.gypi') diff --git a/skia/skia_library.gypi b/skia/skia_library.gypi index a93f6d5..4e1139a 100644 --- a/skia/skia_library.gypi +++ b/skia/skia_library.gypi @@ -398,6 +398,15 @@ '-Wstring-conversion', ], }], + # On windows, GDI handles are a scarse system-wide resource so we have to keep + # the glyph cache, which holds up to 4 GDI handles per entry, to a fairly small + # size. + # http://crbug.com/314387 + [ 'OS == "win"', { + 'defines': [ + 'SK_DEFAULT_FONT_CACHE_COUNT_LIMIT=256', + ], + }], ], 'target_conditions': [ # Pull in specific Mac files for iOS (which have been filtered out @@ -440,9 +449,6 @@ 'SK_GDI_ALWAYS_USE_TEXTMETRICS_FOR_FONT_METRICS', 'SK_DEFAULT_FONT_CACHE_LIMIT=<(default_font_cache_limit)', - - # http://crbug.com/314387 - 'SK_DEFAULT_FONT_CACHE_COUNT_LIMIT=64', ], 'direct_dependent_settings': { -- cgit v1.1