From 847ace1c673d3eb733c3210bbf8f7c19ac1eb63b Mon Sep 17 00:00:00 2001 From: stanisc Date: Fri, 11 Dec 2015 20:17:15 -0800 Subject: Sync: Remove GetEntry() from BaseNode API. 1) Changed BaseNode::GetEntry() to be protected. 2) Introduced a couple of getters to expose some of the functionality that GetEntry() was used for. 3) Made all necessary changes to avoid calling GetEntry() outside of BaseNode, ReadNode, WriteNode, and a few specific unit tests. BUG=123674 Review URL: https://codereview.chromium.org/1517013004 Cr-Commit-Position: refs/heads/master@{#364901} --- sync/syncable/entry.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sync/syncable/entry.h') diff --git a/sync/syncable/entry.h b/sync/syncable/entry.h index 0c30ccd..47a7815 100644 --- a/sync/syncable/entry.h +++ b/sync/syncable/entry.h @@ -110,12 +110,12 @@ class SYNC_EXPORT Entry { return kernel_->ref(SERVER_CTIME); } - Id GetId() const { + const Id& GetId() const { DCHECK(kernel_); return kernel_->ref(ID); } - Id GetParentId() const { + const Id& GetParentId() const { DCHECK(kernel_); return kernel_->ref(PARENT_ID); } -- cgit v1.1