From 1dea9fcdc7170f94b562f76354b1ed2b37052e05 Mon Sep 17 00:00:00 2001 From: "simon.fraser@apple.com" Date: Tue, 19 Jul 2011 20:32:58 +0000 Subject: 2011-07-19 Simon Fraser Possible recursion in GraphicsLayerCA::updateGeometry() https://bugs.webkit.org/show_bug.cgi?id=64815 Reviewed by Sam Weinig. It was possible to recurse via updateGeometry/swapFromOrToTiledLayer/ updateContentsScale because updateGeometry() and updateContentsScale() used different sizes; updateGeometry() used the scaled size, while updateContentsScale() used the unscaled size. Always use the unscaled size; the scaled size will be at most a couple of pixels bigger, and our threshold is not close to the max texture size limit, so using the slightly smaller size is OK. Test: compositing/scaling/tiled-layer-recursion.html * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateGeometry): (WebCore::GraphicsLayerCA::updateLayerDrawsContent): (WebCore::GraphicsLayerCA::updateContentsScale): (WebCore::GraphicsLayerCA::requiresTiledLayer): * platform/graphics/ca/GraphicsLayerCA.h: git-svn-id: svn://svn.chromium.org/blink/trunk@91294 bbb929c8-8fbe-4397-9dbb-9b2b20218538 --- .../compositing/scaling/tiled-layer-recursion.html | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html (limited to 'third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html') diff --git a/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html b/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html new file mode 100644 index 0000000..f8b189f --- /dev/null +++ b/third_party/WebKit/LayoutTests/compositing/scaling/tiled-layer-recursion.html @@ -0,0 +1,29 @@ + + + + + + + + + +

+ + -- cgit v1.1