From 9f58d8bb68966e20fc2809e221d925b895ca762e Mon Sep 17 00:00:00 2001 From: "evanm@google.com" Date: Wed, 20 Aug 2008 22:56:30 +0000 Subject: Turn on -Wall -Werror, fixing a few files while I'm here and *temporarily* disabling some other warnings that take more effort to fix. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1123 0039d316-1c4b-4281-b951-d872f2087c98 --- third_party/bsdiff/mbsdiff.cc | 2 +- third_party/bspatch/SConscript | 4 ++++ third_party/libjpeg/SConscript | 4 ++++ third_party/libxml/SConscript | 3 +++ 4 files changed, 12 insertions(+), 1 deletion(-) (limited to 'third_party') diff --git a/third_party/bsdiff/mbsdiff.cc b/third_party/bsdiff/mbsdiff.cc index 29227e8..1dcd35e 100644 --- a/third_party/bsdiff/mbsdiff.cc +++ b/third_party/bsdiff/mbsdiff.cc @@ -379,4 +379,4 @@ int main(int argc,char *argv[]) free(newbuf); return 0; -} \ No newline at end of file +} diff --git a/third_party/bspatch/SConscript b/third_party/bspatch/SConscript index 7f93b68..d7eef03 100644 --- a/third_party/bspatch/SConscript +++ b/third_party/bspatch/SConscript @@ -52,6 +52,10 @@ if env['PLATFORM'] == 'win32': '/wd4800', ], ) +elif env['PLATFORM'] == 'posix': + if '-Wall' in env['CCFLAGS']: + # We're not responsible for bad warning hygiene in this third party code. + env['CCFLAGS'].remove('-Wall') input_files = [ 'mbspatch.cc', diff --git a/third_party/libjpeg/SConscript b/third_party/libjpeg/SConscript index 5c4fce7..f25beb1 100644 --- a/third_party/libjpeg/SConscript +++ b/third_party/libjpeg/SConscript @@ -45,6 +45,10 @@ if env['PLATFORM'] == 'win32': '/wd4800', ], ) +elif env['PLATFORM'] == 'posix': + if '-Wall' in env['CCFLAGS']: + # We're not responsible for bad warning hygiene in this third party code. + env['CCFLAGS'].remove('-Wall') input_files = [ 'jcapimin.c', diff --git a/third_party/libxml/SConscript b/third_party/libxml/SConscript index 40619e3..3a0c00a 100644 --- a/third_party/libxml/SConscript +++ b/third_party/libxml/SConscript @@ -62,6 +62,9 @@ elif env['PLATFORM'] == 'posix': '_REENTRANT', ], ) + if '-Wall' in env['CCFLAGS']: + # We're not responsible for bad warning hygiene in this third party code. + env['CCFLAGS'].remove('-Werror') input_files = [ -- cgit v1.1