From 1a150551a669a94dbdc316b452721b721354bedc Mon Sep 17 00:00:00 2001 From: "wangxianzhu@chromium.org" Date: Mon, 10 Mar 2014 18:23:38 +0000 Subject: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only - Remove DCHECK in non-official-release build by default - Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK in release build - Remove flag --enable-dcheck Other effects/notes: - Now allow "buildtype=Official dcheck_always_on=1" (which will enable DCHECK in official build) combination. - Gyp variable logging_like_official_build no longer has an effect - Leave DCHECK_IS_ON() unchanged. May deal with it in a later change if needed. This won't affect bots which use dcheck_always_on=1. BUG=350462 TEST=LoggingTest.Dcheck R=thakis@chromium.org TBR=darin,sehr (command line changes in components/nacl and mojo) Review URL: https://codereview.chromium.org/189603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/android/forwarder2/daemon.cc | 2 -- 1 file changed, 2 deletions(-) (limited to 'tools/android') diff --git a/tools/android/forwarder2/daemon.cc b/tools/android/forwarder2/daemon.cc index 0a7e502..d753302 100644 --- a/tools/android/forwarder2/daemon.cc +++ b/tools/android/forwarder2/daemon.cc @@ -46,8 +46,6 @@ void InitLoggingForDaemon(const std::string& log_file) { logging::LOG_TO_SYSTEM_DEBUG_LOG : logging::LOG_TO_FILE; settings.log_file = log_file.c_str(); settings.lock_log = logging::DONT_LOCK_LOG_FILE; - settings.dcheck_state = - logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS; CHECK(logging::InitLogging(settings)); } -- cgit v1.1