From 585d8572b693eae0c617a0a0aac937fe31b8c371 Mon Sep 17 00:00:00 2001 From: qyearsley Date: Thu, 12 Mar 2015 17:26:58 -0700 Subject: Make error message for out-of-order revisions more detailed. BUG=466737 Review URL: https://codereview.chromium.org/1006613003 Cr-Commit-Position: refs/heads/master@{#320412} --- tools/auto_bisect/bisect_perf_regression.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'tools/auto_bisect') diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py index 6c49a98..033de20 100755 --- a/tools/auto_bisect/bisect_perf_regression.py +++ b/tools/auto_bisect/bisect_perf_regression.py @@ -1978,6 +1978,8 @@ class BisectPerformanceMetrics(object): bad_position = source_control.GetCommitPosition(bad_revision, cwd) # Compare commit timestamp for repos that don't support commit position. if not (bad_position and good_position): + logging.info('Could not get commit positions for revisions %s and %s in ' + 'depot %s', good_position, bad_position, target_depot) good_position = source_control.GetCommitTime(good_revision, cwd=cwd) bad_position = source_control.GetCommitTime(bad_revision, cwd=cwd) @@ -2204,8 +2206,8 @@ class BisectPerformanceMetrics(object): # Check that they didn't accidentally swap good and bad revisions. if not self.CheckIfRevisionsInProperOrder( target_depot, good_revision, bad_revision): - return BisectResults(error='bad_revision < good_revision, did you swap ' - 'these by mistake?') + return BisectResults(error='Bad rev (%s) appears to be earlier than good ' + 'rev (%s).' % (good_revision, bad_revision)) bad_revision, good_revision = self.NudgeRevisionsIfDEPSChange( bad_revision, good_revision, good_revision_in) -- cgit v1.1