From 31a46dfacc2c4e856f81ab6bbe6dbb2b6127333e Mon Sep 17 00:00:00 2001 From: "torne@chromium.org" Date: Thu, 31 May 2012 09:25:47 +0000 Subject: The LASTCHANGE file is created and updated by gclient runhooks under normal circumstances, so it makes more sense to treat it as if it were a checked-in source file, not a generated file. The rule for its generation was still getting run once on a clean build, because the other targets that depended on it expected a gyp timestamp file to exist for the target. There's no need for any other targets to actually depend on lastchange (and in fact several of the targets that make use of the file already don't depend on the target); it should already exist, and if it doesn't then the source checkout is probably broken (as the other steps in runhooks are also mandatory). So, remove the rule entirely. Review URL: https://chromiumcodereview.appspot.com/10388213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139765 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/export_tarball/export_tarball.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'tools/export_tarball') diff --git a/tools/export_tarball/export_tarball.py b/tools/export_tarball/export_tarball.py index 861503e..ac366db 100755 --- a/tools/export_tarball/export_tarball.py +++ b/tools/export_tarball/export_tarball.py @@ -1,5 +1,5 @@ #!/usr/bin/env python -# Copyright (c) 2011 The Chromium Authors. All rights reserved. +# Copyright (c) 2012 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -101,6 +101,12 @@ def main(argv): print 'Cannot find the src directory.' return 1 + # This command is from src/DEPS; please keep them in sync. + if subprocess.call(['python', 'build/util/lastchange.py', '-o', + 'build/util/LASTCHANGE'], cwd=GetSourceDirectory()) != 0: + print 'Could not run build/util/lastchange.py to update LASTCHANGE.' + return 1 + output_fullname = args[0] + '.tar.bz2' output_basename = os.path.basename(args[0]) -- cgit v1.1