From ef348fe5461c9b73f9cc64b9be96afde984dd9c7 Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Thu, 1 May 2014 18:31:31 +0000 Subject: Add implicit hard deps to GN. Automatically deduce the hard dependency flag from the target type. Code targets never have side effects that require the hard dep flag, and actions almost always do. This additionally forces all hard deps of all recursive dependencies of a target to be order-only deps of a target. This solves the problem of indirectly depending on an action that generates a source file and depending on the results of that action. Previously (and in GYP) this would result in cases where the first build is wrong. To avoid an explosion of hard deps on each source file, this adds an input dependency stamp file to coalesce these hard deps, so each source needs only one order-only dependency. This stamp file is written if there are any order-only dependencies, even in cases where there is only one and we might be better off skipping this and writing it directly. The additional performance from doing this didn't seem worth adding the additional complexity for the optimization. TBR=scottmg@chromium.org Original review: https://codereview.chromium.org/259353002 Review URL: https://codereview.chromium.org/269463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267593 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/gn/variables.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'tools/gn/variables.h') diff --git a/tools/gn/variables.h b/tools/gn/variables.h index 80404ae..020e25b 100644 --- a/tools/gn/variables.h +++ b/tools/gn/variables.h @@ -127,10 +127,6 @@ extern const char kForwardDependentConfigsFrom[]; extern const char kForwardDependentConfigsFrom_HelpShort[]; extern const char kForwardDependentConfigsFrom_Help[]; -extern const char kHardDep[]; -extern const char kHardDep_HelpShort[]; -extern const char kHardDep_Help[]; - extern const char kIncludeDirs[]; extern const char kIncludeDirs_HelpShort[]; extern const char kIncludeDirs_Help[]; -- cgit v1.1