From 6ac14382da4a3fca0e1fa3353bbfc5b7ba93d4b4 Mon Sep 17 00:00:00 2001 From: "shess@chromium.org" <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Sat, 2 Nov 2013 21:08:27 +0000 Subject: [sql] Ship Favicons recovery code to beta and stable. The code has been running without event on dev and canary for many weeks, the histograms have changed in a manner consistent with databases no longer being corrupt. Everyone should share this. Add some histograms to track the amount of data recovered. BUG=240396 Review URL: https://codereview.chromium.org/49673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232635 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/metrics/histograms/histograms.xml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) (limited to 'tools/metrics/histograms') diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 4f0fcbf..85787bf 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -5065,6 +5065,32 @@ other types of suffix sets. </summary> </histogram> +<histogram name="History.FaviconsRecoveredPercentage" units="%"> + <summary> + Size of the recovered Favicons database relative to the original corrupt + database. Recovery is VACUUM-like, so the resulting database should always + be smaller. Substantial 100% results would indicate empty databases being + recovered, substantial low% results would indicate very little data being + recovered. + </summary> +</histogram> + +<histogram name="History.FaviconsRecoveredRowsFaviconBitmaps"> + <summary> + Rows recovered from [favicon_bitmaps] table in Favicons recovery. + </summary> +</histogram> + +<histogram name="History.FaviconsRecoveredRowsFavicons"> + <summary>Rows recovered from [favicons] table in Favicons recovery.</summary> +</histogram> + +<histogram name="History.FaviconsRecoveredRowsIconMapping"> + <summary> + Rows recovered from [icon_mapping] table in Favicons recovery. + </summary> +</histogram> + <histogram name="History.FaviconsRecovery" enum="HistoryFaviconsRecoveryEnum"> <summary> Track results of SQLite database recovery code in thumbnail_database.cc. -- cgit v1.1