From aa8dc1286c769e398a4512e4a6dce1cb38c823af Mon Sep 17 00:00:00 2001 From: "timurrrr@chromium.org" Date: Wed, 3 Nov 2010 10:45:41 +0000 Subject: Ignore zlib:inflate under TSan This would suppress reports like: http://build.chromium.org/p/chromium.fyi/builders/Linux%20Tests%20(tsan%20ui)/builds/259/steps/memory%20test:%20ui_9/logs/stdio ==14031== WARNING: Possible data race during read of size 4 at 0x801497C: {{{ ==14031== T0 (L{L37, L165}): ==14031== #0 ???//usr/lib/pango/1.6.0/modules/pango-arabic-lang.so /usr/lib/pango/1.6.0/modules/pango-arabic-lang.so ==14031== #1 pthread_mutex_lock /tmp/valgrind-src/tsan/tsan/ts_valgrind_intercepts.c:892 ==14031== #2 dlopen_doit /lib/tls/i686/cmov/libdl-2.7.so ==14031== #3 _dlerror_run /lib/tls/i686/cmov/libdl-2.7.so ... ==14031== Concurrent write(s) happened at (OR AFTER) these points: ==14031== T8 (Chrome_IOThread) (L{}): ==14031== #0 inflate_fast /build/buildd/zlib-1.2.3.3.dfsg/inffast.c:270 ==14031== #1 inflate /build/buildd/zlib-1.2.3.3.dfsg/inflate.c:954 ==14031== #2 GZipFilter::DoInflate(char*, int*) net/base/gzip_filter.cc:226 ==14031== #3 GZipFilter::ReadFilteredData(char*, int*) net/base/gzip_filter.cc:141 This may also speed TSan up a little bit. TBR=glider Review URL: http://codereview.chromium.org/4341003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64898 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/valgrind/tsan/ignores.txt | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tools/valgrind/tsan/ignores.txt') diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index 3e6e499..2128996 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -101,3 +101,6 @@ fun_r:threadLockingTest # There is a benign race which is hard to suppress properly, # see http://crbug.com/44580 fun_r:*BrowserThread*GetCurrentThreadIdentifier* + +# zlib is smarter than we are, see http://www.zlib.net/zlib_faq.html#faq36 +fun_r:inflate -- cgit v1.1