From 501f9685a8bfcd5a819fd1022f229eb5a1922cc8 Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Mon, 16 Jul 2012 21:45:27 +0000 Subject: Revert 146792 - Lock-free GamepadSeqLock (try 2) [Reverted due to crashing in ChromeBot with following stack: content::internal::GamepadSeqLockBase::ReadTo+0x1a content::GamepadSharedMemoryReader::SampleGamepads+0xaa RendererWebKitPlatformSupportImpl::sampleGamepads+0x57 WebCore::sampleGamepads+0x3f WebCore::NavigatorGamepad::gamepads+0x71 WebCore::NavigatorV8Internal::webkitGamepadsAttrGetter+0x45 v8::internal::JSObject::GetPropertyWithCallback+0x252] The change - provides an improved lock-free SeqLock implementation which eliminates any potential blocking of readers. - provides a higher-level and simpler API as was suggested by Darin. - ThreadSanitizer report suppressions are replaced with correct synchronization. - eliminates nasty kMaximumContentionCount and associated histogram. Oritignal review URL: http://codereview.chromium.org/8772004 TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10704041 TBR=dvyukov@chromium.org Review URL: https://chromiumcodereview.appspot.com/10785024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146896 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/valgrind/tsan/ignores.txt | 2 -- 1 file changed, 2 deletions(-) (limited to 'tools/valgrind/tsan') diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index ac677b8..7f28d10 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -60,8 +60,6 @@ src:*base/synchronization/waitable_event* # Don't instrument code dealing with atomics (base::subtle) fun:*base*subtle*Release_Store* -fun:*base*subtle*NoBarrier_Store* -fun:*base*subtle*Acquire_Load* fun:*base*subtle*NoBarrier_CompareAndSwap* fun:*base*subtle*NoBarrier_Load* # Keep some mangling so we don't match NoBarrier_AtomicIncrement -- cgit v1.1