From e79d7dc73530396c27806a6794f4fcd65262926f Mon Sep 17 00:00:00 2001 From: "sail@chromium.org" Date: Wed, 6 Apr 2011 20:47:09 +0000 Subject: Fix leak in ProfileMenuButtonTest.MenuTest Valgrind was reporting a leak in -[ProfileMenuDelegate menuWillOpen:]. I wasn't able to reproduce this on my machine with a Debug or Release build. As a workaround I'm simply removing that part of the test. The test now just checks that popUpContextMenu:withEvent:forView: is called. This is still pretty good since it tests the mouse down code and the pressed state drawing code. BUG=77910 TEST=Wasn't able to reproduce the same leak but I did get some other leaks in the menu code. Applied my patch and verified that valgrind ran with no errors. Review URL: http://codereview.chromium.org/6677169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80687 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/valgrind/memcheck/suppressions_mac.txt | 23 ----------------------- 1 file changed, 23 deletions(-) (limited to 'tools/valgrind') diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt index 5888c50..05c4b01 100644 --- a/tools/valgrind/memcheck/suppressions_mac.txt +++ b/tools/valgrind/memcheck/suppressions_mac.txt @@ -1569,26 +1569,3 @@ fun:_ZN20SelectFileDialogImpl10SelectFileEN16SelectFileDialog4TypeERKSbItN4base20string16_char_traitsESaItEERK8FilePathPKNS0_12FileTypeInfoEiRKSsP8NSWindowPv fun:_ZN15DownloadManager24OnPathExistenceAvailableEP18DownloadCreateInfo } -{ - bug_77910 - Memcheck:Leak - ... - fun:-[NSObject(NSDelayedPerforming) performSelector:withObject:afterDelay:inModes:] - fun:-[ProfileMenuDelegate menuWillOpen:] - fun:-[NSMenu _sendMenuOpeningNotification] - fun:AppKitApplicationEventHandler - fun:_Z23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec - fun:_Z30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec - fun:SendEventToEventTargetWithOptions - fun:_Z15SendMenuOpeningP14MenuSelectDataP8MenuDatadmP14__CFDictionaryhPh - fun:_Z19PopUpMenuSelectCoreP8MenuData5PointdS1_tjPK4RecttmS4_S4_PK10__CFStringPP13OpaqueMenuRefPt - fun:_HandlePopUpMenuSelection7 - fun:_NSPopUpCarbonMenu3 - fun:_NSPopUpCarbonMenu2 - fun:_NSPopUpCarbonMenu1 - fun:-[NSCarbonMenuImpl _popUpContextMenu:withEvent:forView:withFont:] - fun:-[NSMenu _popUpContextMenu:withEvent:forView:withFont:] - fun:-[NSMenu _popUpContextMenu:withEvent:forView:] - fun:-[ProfileMenuButton mouseDown:] - fun:_ZN35ProfileMenuButtonTest_MenuTest_Test8TestBodyEv -} -- cgit v1.1