From d4d772ea090aa8c073e93243ddee9c1258661cda Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" Date: Wed, 20 Aug 2014 19:31:10 +0000 Subject: Don't pass const strings to CreateProcess. The documentation says that CreateProcess() can modify its second parameter in UNICODE builds. BUG=396705 R=scottmg@chromium.org, vitalybuka@chromium.org TBR=cpu Review URL: https://codereview.chromium.org/487303004 Cr-Commit-Position: refs/heads/master@{#290890} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290890 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/win/link_limiter/limiter.cc | 2 +- tools/win/split_link/split_link.cc | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'tools/win') diff --git a/tools/win/link_limiter/limiter.cc b/tools/win/link_limiter/limiter.cc index b8a5d1c..cbb1f2a 100644 --- a/tools/win/link_limiter/limiter.cc +++ b/tools/win/link_limiter/limiter.cc @@ -74,7 +74,7 @@ static DWORD RunExe(const tstring& exe_name) { } if (!CreateProcess(NULL, // lpApplicationName - const_cast(cmdline.c_str()), + &cmdline[0], NULL, // lpProcessAttributes NULL, // lpThreadAttributes TRUE, // bInheritHandles diff --git a/tools/win/split_link/split_link.cc b/tools/win/split_link/split_link.cc index dab0618..3dd9118 100644 --- a/tools/win/split_link/split_link.cc +++ b/tools/win/split_link/split_link.cc @@ -135,8 +135,7 @@ static void RunLinker(const vector& prefix, const wchar_t* msg) { fflush(stdout); } if (!CreateProcess(NULL, - reinterpret_cast(const_cast( - cmd.c_str())), + &cmd[0], NULL, NULL, TRUE, -- cgit v1.1