From 0c2ebef56c7d9b32a4df60fac57469e60b0c43c7 Mon Sep 17 00:00:00 2001 From: "phoglund@chromium.org" Date: Wed, 3 Apr 2013 12:14:10 +0000 Subject: Revert 192041 "Splits SmoothGestureController from RenderWidgetH..." > Splits SmoothGestureController from RenderWidgetHostImpl > > Elements were pushed when the platform sends an input event, > but they're are popped when the event are ACKd. > There are other internal queues such as "touch_event_queue_" and > "gesture_filter_" that may coalesce / ACK events using their own internal > order. > This results in in_process_event_types_ not being popped correctly, and > prevents Telemetry from synthesizing Motion events on android. > The solution is to move the synthetic events out of RenderWidgetHostImpl and use a simple counter there. > > BUG=166521 > TEST=content_unittest, SmoothScrollGestureControllerTest > > Review URL: https://chromiumcodereview.appspot.com/11858007 TBR=bulach@chromium.org Review URL: https://codereview.chromium.org/13408009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192054 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/telemetry/telemetry/page/actions/scroll.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'tools') diff --git a/tools/telemetry/telemetry/page/actions/scroll.js b/tools/telemetry/telemetry/page/actions/scroll.js index 32952cc..2ccfece 100644 --- a/tools/telemetry/telemetry/page/actions/scroll.js +++ b/tools/telemetry/telemetry/page/actions/scroll.js @@ -73,13 +73,9 @@ chrome.gpuBenchmarking && chrome.gpuBenchmarking.smoothScrollBy) { var rect = getBoundingVisibleRect(this.element_); - var scrolled = chrome.gpuBenchmarking.smoothScrollBy( - distance, function() { - callback(); - }, - rect.left + rect.width / 2, rect.top + rect.height / 2); - if (!scrolled) - console.log('Unable to start smooth scrolling'); + chrome.gpuBenchmarking.smoothScrollBy(distance, function() { + callback(); + }, rect.left + rect.width / 2, rect.top + rect.height / 2); return; } -- cgit v1.1