From 22e2f4a23530e0b22c8f37dd91e4e803a0a6e355 Mon Sep 17 00:00:00 2001 From: wfh Date: Tue, 28 Apr 2015 15:39:21 -0700 Subject: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination. Wire this into all the existing callers. Add a new child process watcher in chrome to be notified on child process crashes. This will confirm whether users with RESULT_CODE_INVALID_SANDBOX_STATE are crashing on background start (--no-startup-window) or not. This also adds required framework to paint a sad tab UI from this class in the future. BUG=472324, 453541 TEST=Apply patch in http://pastebin.com/uEDxngBa and verify histogram ChildProcess.InvalidSandboxStateCrash.NoStartupWindow is recorded. Review URL: https://codereview.chromium.org/1067733006 Cr-Commit-Position: refs/heads/master@{#327380} --- tools/metrics/histograms/histograms.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'tools') diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 87a141d..13faa04 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -2772,6 +2772,17 @@ Therefore, the affected-histogram name has to have at least one dot in it. + + wfh@chromium.org + + Whether the browser command line had the switch --no-startup-window when a + child process crashed due to invalid sandbox state. Recorded when a child + process crashes if the exit code from the child process is + RESULT_CODE_INVALID_SANDBOX_STATE. + + + Deprecated 3/2013. Renamed to ChildProcess.Killed2. -- cgit v1.1