From 58026e262a8932be5f0ebd75d4744232f6327e2d Mon Sep 17 00:00:00 2001 From: "rnk@chromium.org" Date: Thu, 19 Jan 2012 20:23:22 +0000 Subject: Exclude JingleSessionTest.TestMultistepAuthTcpChannel from drmemory. This test fails locally for me when run under DrMemory. On the bots, it passes but generates uninit reports. JingleSessionTest.TestTcpChannel is almost identical, and it is also excluded. TestMultistepAuthTcpChannel takes 260s on the bots, which is probably not a good use of bot resources, so I'm excluding it. Removing the suppressions I added for it. TBR=bruening@chromium.org BUG=110729 TEST=none Review URL: https://chromiumcodereview.appspot.com/9200008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118345 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/valgrind/drmemory/suppressions_full.txt | 34 +--------------------- .../remoting_unittests.gtest-drmemory_win32.txt | 1 + 2 files changed, 2 insertions(+), 33 deletions(-) (limited to 'tools') diff --git a/tools/valgrind/drmemory/suppressions_full.txt b/tools/valgrind/drmemory/suppressions_full.txt index 6fd756c..3de3ce0 100644 --- a/tools/valgrind/drmemory/suppressions_full.txt +++ b/tools/valgrind/drmemory/suppressions_full.txt @@ -156,6 +156,7 @@ WINSPOOL.DRV!* UNINITIALIZED READ name=http://code.google.com/p/drmemory/issues/detail?id=48 a system call NtContinue +... *!*SetThreadName UNINITIALIZED READ @@ -742,15 +743,6 @@ UNINITIALIZED READ name=http://code.google.com/p/drmemory/issues/detail?id=493 USP10.dll!ScriptPositionSingleGlyph -# Requires investigation, looks like syscall false pos. -UNINITIALIZED READ -name=http://code.google.com/p/drmemory/issues/detail?id=758 -system call NtContinue -ntdll.dll!KiUserExceptionDispatcher -KERNEL*.dll!* -KERNEL*.dll!RaiseException -*!talk_base::SetThreadName - ############################################################### # Benign issues in Chromium @@ -930,27 +922,3 @@ name=http://crbug.com/110049 *!media::DoCrossfade<*> *!media::Crossfade *!media::AudioRendererAlgorithmBase::FillBuffer - -# Possible real Chromium issue in JingleSessionTest.TestMultistepAuthTcpChannel. -# Need to make sure talk_base::FifoBuffer ctor is getting called. Doesn't look -# like DrMemory unhandled syscall. -UNINITIALIZED READ -name=http://crbug.com/110729 a -... -*!jingle_glue::PseudoTcpAdapter::Write - -UNINITIALIZED READ -name=http://crbug.com/110729 b -... -*!jingle_glue::PseudoTcpAdapter::Read - -UNINITIALIZED READ -name=http://crbug.com/110729 c -... -*!jingle_glue::PseudoTcpAdapter::Core::HandleTcpClock - -# Not clear how this test is calling memcmp directly; bad stack? -UNINITIALIZED READ -name=http://crbug.com/110729 d -drmemorylib.dll!replace_memcmp -*!remoting::protocol::JingleSessionTest_TestMultistepAuthTcpChannel_Test::TestBody diff --git a/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt b/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt index a21737c..7f01481 100644 --- a/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt +++ b/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt @@ -3,6 +3,7 @@ JingleSessionTest.Connect JingleSessionTest.TestUdpChannel JingleSessionTest.TestTcpChannel +JingleSessionTest.TestMultistepAuthTcpChannel JingleSessionTest.TestSpeed # This test fails on an assertion, see http://crbug.com/57266 -- cgit v1.1