From b089fdfcd630f5adf11b73c6926c273b2279b27a Mon Sep 17 00:00:00 2001 From: "cmp@chromium.org" Date: Mon, 28 Mar 2011 23:54:51 +0000 Subject: Fix make_expectations.py for "new" expectations. BUG=none TEST=make_expectations.py works for previously unknown expectations (those without regress/improve values) TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/6765004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79634 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/perf_expectations/make_expectations.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'tools') diff --git a/tools/perf_expectations/make_expectations.py b/tools/perf_expectations/make_expectations.py index 4f8cc0f..ebe1a6a 100755 --- a/tools/perf_expectations/make_expectations.py +++ b/tools/perf_expectations/make_expectations.py @@ -224,7 +224,8 @@ def Main(args): # If the existing values assume regressions are low deltas relative to # improvements, swap our regress and improve. This value must be a # scores-like result. - if perf[key]['regress'] < perf[key]['improve']: + if ('regress' in perf[key] and 'improve' in perf[key] and + perf[key]['regress'] < perf[key]['improve']): temp = regress regress = improve improve = temp @@ -235,7 +236,8 @@ def Main(args): improve = int(math.floor(improve - abs(improve*variance))) regress = int(math.ceil(regress + abs(regress*variance))) - if (perf[key]['regress'] == regress and perf[key]['improve'] == improve): + if ('regress' in perf[key] and 'improve' in perf[key] and + perf[key]['regress'] == regress and perf[key]['improve'] == improve): print '%s (no change)' % key continue -- cgit v1.1