From a4462ff0f8422a8ad055b1b88d619a16bacb400d Mon Sep 17 00:00:00 2001
From: ryoh <ryoh@chromium.org>
Date: Tue, 1 Mar 2016 22:29:32 -0800
Subject: Gallery: init mode before loading thumbnail & load thumbnails for
 selected images first.

BUG=577345
TEST=manually

Review URL: https://codereview.chromium.org/1756003002

Cr-Commit-Position: refs/heads/master@{#378705}
---
 ui/file_manager/gallery/js/gallery.js | 65 ++++++++++++++++++++---------------
 1 file changed, 37 insertions(+), 28 deletions(-)

(limited to 'ui/file_manager')

diff --git a/ui/file_manager/gallery/js/gallery.js b/ui/file_manager/gallery/js/gallery.js
index 3447acc..13c0020 100644
--- a/ui/file_manager/gallery/js/gallery.js
+++ b/ui/file_manager/gallery/js/gallery.js
@@ -387,11 +387,21 @@ Gallery.prototype.loadInternal_ = function(entries, selectedEntries) {
     return;
   }
 
+  // Sort the selected image first
+  var containsInSelection = function(galleryItem) {
+    return selectedEntries.indexOf(galleryItem.getEntry()) >= 0;
+  };
+  var notContainsInSelection = function(galleryItem) {
+    return !containsInSelection(galleryItem);
+  };
+  items = items.filter(containsInSelection)
+      .concat(items.filter(notContainsInSelection));
+
   // Load entries.
   // Use the self variable capture-by-closure because it is faster than bind.
   var self = this;
   var thumbnailModel = new ThumbnailModel(this.metadataModel_);
-  var loadChunk = function(firstChunk) {
+  var loadChunk = function() {
     // Extract chunk.
     var chunk = items.splice(0, maxChunkSize);
     if (!chunk.length)
@@ -416,36 +426,35 @@ Gallery.prototype.loadInternal_ = function(entries, selectedEntries) {
         self.dataModel_.dispatchEvent(event);
       });
 
-      // Init modes after the first chunk is loaded.
-      if (firstChunk && !self.initialized_) {
-        // Determine the initial mode.
-        var shouldShowThumbnail = selectedEntries.length > 1 ||
-            (self.context_.pageState &&
-             self.context_.pageState.gallery === 'thumbnail');
-        self.setCurrentMode_(
-            shouldShowThumbnail ? self.thumbnailMode_ : self.slideMode_);
-
-        // Do the initialization for each mode.
-        if (shouldShowThumbnail) {
-          self.thumbnailMode_.show();
-          self.thumbnailMode_.focus();
-        } else {
-          self.slideMode_.enter(
-              null,
-              function() {
-                // Flash the toolbar briefly to show it is there.
-                self.dimmableUIController_.kick(Gallery.FIRST_FADE_TIMEOUT);
-              },
-              function() {});
-        }
-        self.initialized_ = true;
-      }
-
       // Continue to load chunks.
-      return loadChunk(/* firstChunk */ false);
+      return loadChunk();
     });
   };
-  loadChunk(/* firstChunk */ true).catch(function(error) {
+  // init modes before loading images.
+  if (!this.initialized_) {
+    // Determine the initial mode.
+    var shouldShowThumbnail = selectedEntries.length > 1 ||
+        (this.context_.pageState &&
+         this.context_.pageState.gallery === 'thumbnail');
+    this.setCurrentMode_(
+        shouldShowThumbnail ? this.thumbnailMode_ : this.slideMode_);
+
+    // Do the initialization for each mode.
+    if (shouldShowThumbnail) {
+      this.thumbnailMode_.show();
+      this.thumbnailMode_.focus();
+    } else {
+      this.slideMode_.enter(
+          null,
+          function() {
+            // Flash the toolbar briefly to show it is there.
+            self.dimmableUIController_.kick(Gallery.FIRST_FADE_TIMEOUT);
+          },
+          function() {});
+    }
+    this.initialized_ = true;
+  }
+  loadChunk().catch(function(error) {
     console.error(error.stack || error);
   });
 };
-- 
cgit v1.1