From cf6cc2ee0f6a8267d5246f490421ac39b40f5b1c Mon Sep 17 00:00:00 2001 From: "yukawa@chromium.org" Date: Tue, 22 Oct 2013 01:44:39 +0000 Subject: Mark getter methods in ui::InputMethod as const This CL marks following methods as "const-method" as a preparation to fix issue 164964. - ui::TextInputClient::GetCaretBounds - ui::TextInputClient::GetCompositionCharacterBounds - ui::TextInputClient::HasCompositionText - ui::TextInputClient::GetTextRange - ui::TextInputClient::GetCompositionTextRang - ui::TextInputClient::GetSelectionRange - ui::TextInputClient::GetTextFromRange BUG=164964 TEST=none Review URL: https://codereview.chromium.org/27812003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230001 0039d316-1c4b-4281-b951-d872f2087c98 --- ui/keyboard/keyboard_controller_unittest.cc | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) (limited to 'ui/keyboard') diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc index 3650520..407cc6a 100644 --- a/ui/keyboard/keyboard_controller_unittest.cc +++ b/ui/keyboard/keyboard_controller_unittest.cc @@ -128,24 +128,27 @@ class TestTextInputClient : public ui::TextInputClient { return ui::TEXT_INPUT_MODE_DEFAULT; } virtual bool CanComposeInline() const OVERRIDE { return false; } - virtual gfx::Rect GetCaretBounds() OVERRIDE { return gfx::Rect(); } + virtual gfx::Rect GetCaretBounds() const OVERRIDE { return gfx::Rect(); } - virtual bool GetCompositionCharacterBounds(uint32 index, - gfx::Rect* rect) OVERRIDE { + virtual bool GetCompositionCharacterBounds( + uint32 index, + gfx::Rect* rect) const OVERRIDE { return false; } - virtual bool HasCompositionText() OVERRIDE { return false; } - virtual bool GetTextRange(gfx::Range* range) OVERRIDE { return false; } - virtual bool GetCompositionTextRange(gfx::Range* range) OVERRIDE { + virtual bool HasCompositionText() const OVERRIDE { return false; } + virtual bool GetTextRange(gfx::Range* range) const OVERRIDE { return false; } + virtual bool GetCompositionTextRange(gfx::Range* range) const OVERRIDE { + return false; + } + virtual bool GetSelectionRange(gfx::Range* range) const OVERRIDE { return false; } - virtual bool GetSelectionRange(gfx::Range* range) OVERRIDE { return false; } virtual bool SetSelectionRange(const gfx::Range& range) OVERRIDE { return false; } virtual bool DeleteRange(const gfx::Range& range) OVERRIDE { return false; } virtual bool GetTextFromRange(const gfx::Range& range, - base::string16* text) OVERRIDE { + base::string16* text) const OVERRIDE { return false; } virtual void OnInputMethodChanged() OVERRIDE {} -- cgit v1.1