From 78e363fa39d6edd2b8e3472b294c11b612af32e6 Mon Sep 17 00:00:00 2001 From: dnicoara Date: Thu, 5 Mar 2015 20:29:08 -0800 Subject: [Ozone-Drm] Replace some LOGs with PLOGs and some with VLOGs Log messages that are less critical were moved to VLOG(2) so they won't show up by default. The others have been changed to PLOGs so that we get more information on why the kernel rejected the DRM calls. BUG=none Review URL: https://codereview.chromium.org/970323002 Cr-Commit-Position: refs/heads/master@{#319410} --- .../drm/gpu/hardware_display_plane_manager_legacy.cc | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) (limited to 'ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc') diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc index 6dacd32..b204508 100644 --- a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc +++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc @@ -36,9 +36,8 @@ bool HardwareDisplayPlaneManagerLegacy::Commit( for (const auto& plane : flip.planes) { if (!drm_->PageFlipOverlay(flip.crtc_id, plane.framebuffer, plane.bounds, plane.src_rect, plane.plane)) { - LOG(ERROR) << "Cannot display plane on overlay: error=" - << strerror(errno) << "crtc=" << flip.crtc - << " plane=" << plane.plane; + PLOG(ERROR) << "Cannot display plane on overlay: crtc=" << flip.crtc + << " plane=" << plane.plane; ret = false; flip.crtc->PageFlipFailed(); break; @@ -48,11 +47,9 @@ bool HardwareDisplayPlaneManagerLegacy::Commit( base::Bind(&CrtcController::OnPageFlipEvent, flip.crtc->AsWeakPtr()))) { if (errno != EACCES) { - LOG(ERROR) << "Cannot page flip: error='" << strerror(errno) << "'" - << " crtc=" << flip.crtc_id - << " framebuffer=" << flip.framebuffer - << " is_sync=" << is_sync; - LOG(ERROR) << "Failed to commit planes"; + PLOG(ERROR) << "Cannot page flip: crtc=" << flip.crtc_id + << " framebuffer=" << flip.framebuffer + << " is_sync=" << is_sync; ret = false; } flip.crtc->PageFlipFailed(); @@ -65,9 +62,8 @@ bool HardwareDisplayPlaneManagerLegacy::Commit( // This plane is being released, so we need to zero it. if (!drm_->PageFlipOverlay(plane->owning_crtc(), 0, gfx::Rect(), gfx::Rect(), plane->plane_id())) { - LOG(ERROR) << "Cannot free overlay: error=" << strerror(errno) - << "crtc=" << plane->owning_crtc() - << " plane=" << plane->plane_id(); + PLOG(ERROR) << "Cannot free overlay: crtc=" << plane->owning_crtc() + << " plane=" << plane->plane_id(); ret = false; break; } -- cgit v1.1