From aa981566a6de2a85a9ab85b5e06f154fc00dad8c Mon Sep 17 00:00:00 2001 From: "tfarina@chromium.org" Date: Fri, 13 Jun 2014 16:29:01 +0000 Subject: url: Properly disable 4267 warning on Windows. BUG=None TEST=gn gen out/Debug_gn --args='os="win"' TBR=scottmg@chromium.org,brettw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/324633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277033 0039d316-1c4b-4281-b951-d872f2087c98 --- url/BUILD.gn | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) (limited to 'url') diff --git a/url/BUILD.gn b/url/BUILD.gn index 1b9172f..ec15c43 100644 --- a/url/BUILD.gn +++ b/url/BUILD.gn @@ -59,10 +59,11 @@ component("url") { configs += [ ":url_icu_config" ] - # if (is_win) { - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - # 'msvs_disabled_warnings': [ 4267, ] - # } + if (is_win) { + cflags = [ + "/wd4267", # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + ] + } deps = [ "//base", @@ -107,10 +108,12 @@ if (!is_android) { # } #} - # if (is_win) { - # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. - # 'msvs_disabled_warnings': [ 4267, ] - # } + if (is_win) { + cflags = [ + # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. + "/wd4267", + ] + } deps = [ ":url", -- cgit v1.1