From e7b056fbacfbffa0907c9bf7319a2629da1fefcf Mon Sep 17 00:00:00 2001 From: "kinuko@chromium.org" Date: Tue, 9 Jul 2013 08:01:21 +0000 Subject: Cleanup: return value and null-callback fixups on AsyncFileUtil interface - Change return value from bool to void, as handling an error in two ways (return value and callback value) adds unnecessary complexity, and it's not handled at all in the current code. - Add a restriction to callbcak: from now callback should never be NULL. Also dropping callback.is_null() checks in the implementation. BUG=241701 TEST=existing tests should pass R=hidehiko@chromium.org, tzik@chromium.org, vandebo@chromium.org Review URL: https://codereview.chromium.org/18580012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210510 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/browser/fileapi/async_file_util_adapter.h | 28 ++++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'webkit/browser/fileapi/async_file_util_adapter.h') diff --git a/webkit/browser/fileapi/async_file_util_adapter.h b/webkit/browser/fileapi/async_file_util_adapter.h index ebe06f8..9da3db9 100644 --- a/webkit/browser/fileapi/async_file_util_adapter.h +++ b/webkit/browser/fileapi/async_file_util_adapter.h @@ -38,68 +38,68 @@ class WEBKIT_STORAGE_BROWSER_EXPORT_PRIVATE AsyncFileUtilAdapter } // AsyncFileUtil overrides. - virtual bool CreateOrOpen( + virtual void CreateOrOpen( scoped_ptr context, const FileSystemURL& url, int file_flags, const CreateOrOpenCallback& callback) OVERRIDE; - virtual bool EnsureFileExists( + virtual void EnsureFileExists( scoped_ptr context, const FileSystemURL& url, const EnsureFileExistsCallback& callback) OVERRIDE; - virtual bool CreateDirectory( + virtual void CreateDirectory( scoped_ptr context, const FileSystemURL& url, bool exclusive, bool recursive, const StatusCallback& callback) OVERRIDE; - virtual bool GetFileInfo( + virtual void GetFileInfo( scoped_ptr context, const FileSystemURL& url, const GetFileInfoCallback& callback) OVERRIDE; - virtual bool ReadDirectory( + virtual void ReadDirectory( scoped_ptr context, const FileSystemURL& url, const ReadDirectoryCallback& callback) OVERRIDE; - virtual bool Touch( + virtual void Touch( scoped_ptr context, const FileSystemURL& url, const base::Time& last_access_time, const base::Time& last_modified_time, const StatusCallback& callback) OVERRIDE; - virtual bool Truncate( + virtual void Truncate( scoped_ptr context, const FileSystemURL& url, int64 length, const StatusCallback& callback) OVERRIDE; - virtual bool CopyFileLocal( + virtual void CopyFileLocal( scoped_ptr context, const FileSystemURL& src_url, const FileSystemURL& dest_url, const StatusCallback& callback) OVERRIDE; - virtual bool MoveFileLocal( + virtual void MoveFileLocal( scoped_ptr context, const FileSystemURL& src_url, const FileSystemURL& dest_url, const StatusCallback& callback) OVERRIDE; - virtual bool CopyInForeignFile( + virtual void CopyInForeignFile( scoped_ptr context, const base::FilePath& src_file_path, const FileSystemURL& dest_url, const StatusCallback& callback) OVERRIDE; - virtual bool DeleteFile( + virtual void DeleteFile( scoped_ptr context, const FileSystemURL& url, const StatusCallback& callback) OVERRIDE; - virtual bool DeleteDirectory( + virtual void DeleteDirectory( scoped_ptr context, const FileSystemURL& url, const StatusCallback& callback) OVERRIDE; - virtual bool DeleteRecursively( + virtual void DeleteRecursively( scoped_ptr context, const FileSystemURL& url, const StatusCallback& callback) OVERRIDE; - virtual bool CreateSnapshotFile( + virtual void CreateSnapshotFile( scoped_ptr context, const FileSystemURL& url, const CreateSnapshotFileCallback& callback) OVERRIDE; -- cgit v1.1