From 39834d692a6f7eab24b30a83327da45baa949bd8 Mon Sep 17 00:00:00 2001
From: "jam@chromium.org"
 <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue, 5 May 2009 07:49:19 +0000
Subject: Fix Flash window in Analytics being incorrectly visible.

The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden.

BUG=8927
TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug
Review URL: http://codereview.chromium.org/106008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15285 0039d316-1c4b-4281-b951-d872f2087c98
---
 webkit/data/plugins/hidden_plugin.html        |  2 ++
 webkit/data/plugins/hidden_plugin_iframe.html | 14 ++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 webkit/data/plugins/hidden_plugin.html
 create mode 100644 webkit/data/plugins/hidden_plugin_iframe.html

(limited to 'webkit/data')

diff --git a/webkit/data/plugins/hidden_plugin.html b/webkit/data/plugins/hidden_plugin.html
new file mode 100644
index 0000000..db6b575
--- /dev/null
+++ b/webkit/data/plugins/hidden_plugin.html
@@ -0,0 +1,2 @@
+<div id='result'>FAIL</div>
+<iframe src='hidden_plugin_iframe.html'></iframe>
\ No newline at end of file
diff --git a/webkit/data/plugins/hidden_plugin_iframe.html b/webkit/data/plugins/hidden_plugin_iframe.html
new file mode 100644
index 0000000..ad0a994
--- /dev/null
+++ b/webkit/data/plugins/hidden_plugin_iframe.html
@@ -0,0 +1,14 @@
+<script>
+var gotVisible = false;
+function windowHidden() {
+  if (!gotVisible)
+    parent.document.getElementById('result').innerHTML = 'DONE';
+}
+
+function windowVisible() {
+  gotVisible = true;
+  parent.document.getElementById('result').innerHTML = 'FAIL';
+}
+
+</script>
+<embed style="visibility:hidden" id='1' type='application/vnd.npapi-test' src='foo' name='hidden_plugin'>
\ No newline at end of file
-- 
cgit v1.1