From 3c6c3d77b20599c6be689d5193b921470d99c037 Mon Sep 17 00:00:00 2001 From: "michaeln@google.com" Date: Sat, 16 Apr 2011 01:13:02 +0000 Subject: Clang build fix, de-inline a virtual method and dtor. TBR=ericu Review URL: http://codereview.chromium.org/6870022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81847 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/fileapi/file_system_callback_dispatcher.cc | 20 ++++++++++++++++++++ webkit/fileapi/file_system_callback_dispatcher.h | 7 ++----- webkit/fileapi/webkit_fileapi.gypi | 1 + 3 files changed, 23 insertions(+), 5 deletions(-) create mode 100644 webkit/fileapi/file_system_callback_dispatcher.cc (limited to 'webkit/fileapi') diff --git a/webkit/fileapi/file_system_callback_dispatcher.cc b/webkit/fileapi/file_system_callback_dispatcher.cc new file mode 100644 index 0000000..1298979 --- /dev/null +++ b/webkit/fileapi/file_system_callback_dispatcher.cc @@ -0,0 +1,20 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "webkit/fileapi/file_system_callback_dispatcher.h" + +#include "base/logging.h" + +namespace fileapi { + +FileSystemCallbackDispatcher::~FileSystemCallbackDispatcher() { +} + +void FileSystemCallbackDispatcher::DidOpenFile( + base::PlatformFile file, + base::ProcessHandle peer_handle) { + NOTREACHED(); +} + +} // namespace fileapi diff --git a/webkit/fileapi/file_system_callback_dispatcher.h b/webkit/fileapi/file_system_callback_dispatcher.h index c32e333..e2d3caa 100644 --- a/webkit/fileapi/file_system_callback_dispatcher.h +++ b/webkit/fileapi/file_system_callback_dispatcher.h @@ -8,7 +8,6 @@ #include #include "base/file_util_proxy.h" -#include "base/logging.h" #include "base/platform_file.h" #include "base/process.h" @@ -21,7 +20,7 @@ namespace fileapi { // but uses chromium types. class FileSystemCallbackDispatcher { public: - virtual ~FileSystemCallbackDispatcher() {} + virtual ~FileSystemCallbackDispatcher(); // Callback for various operations that don't require return values. virtual void DidSucceed() = 0; @@ -58,9 +57,7 @@ class FileSystemCallbackDispatcher { // for Pepper. virtual void DidOpenFile( base::PlatformFile file, - base::ProcessHandle peer_handle) { - NOTREACHED(); - } + base::ProcessHandle peer_handle); }; } // namespace fileapi diff --git a/webkit/fileapi/webkit_fileapi.gypi b/webkit/fileapi/webkit_fileapi.gypi index acb1b4a..b9c79ec 100644 --- a/webkit/fileapi/webkit_fileapi.gypi +++ b/webkit/fileapi/webkit_fileapi.gypi @@ -14,6 +14,7 @@ '<(DEPTH)/net/net.gyp:net', ], 'sources': [ + 'file_system_callback_dispatcher.cc', 'file_system_callback_dispatcher.h', 'file_system_context.cc', 'file_system_context.h', -- cgit v1.1