From 822cfc93fe52974b904b7f184c5448dee5d281c5 Mon Sep 17 00:00:00 2001 From: "deanm@chromium.org" Date: Thu, 12 Feb 2009 14:31:04 +0000 Subject: Match Firefox by not calling SetWindow(NULL) on plugin destruction. This matches the behavior of Firefox on Windows and Linux. This change is especially important for plugin compatability on Linux. This also nicely removes a quirk mode. Review URL: http://codereview.chromium.org/21290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9653 0039d316-1c4b-4281-b951-d872f2087c98 --- webkit/glue/plugins/webplugin_delegate_impl_gtk.cc | 9 --------- 1 file changed, 9 deletions(-) (limited to 'webkit/glue/plugins/webplugin_delegate_impl_gtk.cc') diff --git a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc index 58207c6..58d853e 100644 --- a/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc +++ b/webkit/glue/plugins/webplugin_delegate_impl_gtk.cc @@ -132,15 +132,6 @@ void WebPluginDelegateImpl::DestroyInstance() { // instance uses the helper to do the download. instance_->CloseStreams(); - // TODO(evanm): I played with this for quite a while but couldn't - // figure out a way to make Flash not crash unless I didn't call - // NPP_SetWindow. Perhaps it just should be marked with the quirk - // that wraps the NPP_SetWindow call. - // window_.window = NULL; - // if (!(quirks_ & PLUGIN_QUIRK_DONT_SET_NULL_WINDOW_HANDLE_ON_DESTROY)) { - // instance_->NPP_SetWindow(&window_); - // } - instance_->NPP_Destroy(); instance_->set_web_plugin(NULL); -- cgit v1.1